Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 982fc912fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a shipment box could stage quantities belonging to other boxes. This PR caps bulk and item Scan all at the selected box allocation and remaining issued quantity, and preserves successful receiving data when another refresh request fails. It also applies a saved timezone immediately and completes auth teardown in other tabs after logout, so store users do not remain on an empty transfer detail.
Receiving changes that work with current AccxUI main:
Closes #750. Return findings are recorded separately in #749 and are deferred; this PR makes no return fixes.
Validation at
754b5a4: 84/84 Receiving tests and a production build passed with current AccxUI maine7941af. Two timezone/logout tests failed before the fix and pass afterward; failure-path timezone and other-scope logout tests also pass. Dependencies were reused locally; this was not a clean dependency installation.Fresh Browser UI proof used the paired candidate Receiving
1100ba4+ AccxUI #19769dc97e, against test-maarg/BROOKLYN: selected Box A bulk/repeated/item scan staged exactly 3/2; Box B staged 7/4. A controlled transfer received 3/2 then 7/4, completed at 10/6, and backend QOH increased exactly 60/39 -> 63/41 -> 70/45. Both tabs reached Login after logout from the second tab without reloading; re-login recovered with an empty draft, and receipts remained empty across logout. In the same session, the same backend receipt timestamp displayed 12:46 PM in New York and 9:46 AM after saving Los Angeles, without reloading. This fresh UI evidence is for the paired candidate; standalone UI was not independently rerun. Earlier standalone Demo coverage remains historical evidence.This PR targets main and does not require AccxUI #197. #745 is stacked on this branch and does require #197. No merge or deployment was performed. Physical scanner/iPad/POS, restricted-user roles, customer downstream sync, release PWA upgrade and exact tag packaging remain unverified. The separate tag-release workflow pins an incompatible AccxUI revision and is not fixed here. These checks do not certify all Gorjana flows.
After transfer completion, one Settings navigation changed the URL but left the transfer list visible. Reload recovered the page; repeating normal completed-detail -> list -> Settings navigation then passed. Cause and repeatability remain unproven; this observation is not claimed fixed.