Skip to content

fix: constrain box scanning and preserve receiving refresh results - #746

Closed
dt2patel wants to merge 3 commits into
mainfrom
codex/receiving-standalone-fixes
Closed

dt2patel wants to merge 3 commits into
mainfrom
codex/receiving-standalone-fixes

Conversation

@dt2patel

@dt2patel dt2patel commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Selecting a shipment box could stage quantities belonging to other boxes. This PR caps bulk and item Scan all at the selected box allocation and remaining issued quantity, and preserves successful receiving data when another refresh request fails. It also applies a saved timezone immediately and completes auth teardown in other tabs after logout, so store users do not remain on an empty transfer detail.

Receiving changes that work with current AccxUI main:

  • Constrain selected-box scanning; repeated clicks do not accumulate.
  • Preserve manual iPad keyboard entry while automatic scanner focus avoids the software keyboard.
  • Overlap independent detail/shipment/discrepancy reads while holding the existing operation lock until they settle; persist successful snapshots and keep failed hydration retryable.
  • Overlap independent account/store reads, remove duplicate setup requests, stop permission pagination at the returned total, and reject login when settings fail or are malformed. Preserve previous settings on failure.
  • After a successful timezone preference save, update Luxon defaultZone immediately. Failed saves preserve the previous zone.
  • On same-scope receiving-session logout, stop and clear receiving immediately, then invoke shared auth teardown and Login redirection without another backend logout. Other tenant/user scopes remain isolated.

Closes #750. Return findings are recorded separately in #749 and are deferred; this PR makes no return fixes.

Validation at 754b5a4: 84/84 Receiving tests and a production build passed with current AccxUI main e7941af. Two timezone/logout tests failed before the fix and pass afterward; failure-path timezone and other-scope logout tests also pass. Dependencies were reused locally; this was not a clean dependency installation.

Fresh Browser UI proof used the paired candidate Receiving 1100ba4 + AccxUI #197 69dc97e, against test-maarg/BROOKLYN: selected Box A bulk/repeated/item scan staged exactly 3/2; Box B staged 7/4. A controlled transfer received 3/2 then 7/4, completed at 10/6, and backend QOH increased exactly 60/39 -> 63/41 -> 70/45. Both tabs reached Login after logout from the second tab without reloading; re-login recovered with an empty draft, and receipts remained empty across logout. In the same session, the same backend receipt timestamp displayed 12:46 PM in New York and 9:46 AM after saving Los Angeles, without reloading. This fresh UI evidence is for the paired candidate; standalone UI was not independently rerun. Earlier standalone Demo coverage remains historical evidence.

This PR targets main and does not require AccxUI #197. #745 is stacked on this branch and does require #197. No merge or deployment was performed. Physical scanner/iPad/POS, restricted-user roles, customer downstream sync, release PWA upgrade and exact tag packaging remain unverified. The separate tag-release workflow pins an incompatible AccxUI revision and is not fixed here. These checks do not certify all Gorjana flows.

After transfer completion, one Settings navigation changed the URL but left the transfer list visible. Reload recovered the page; repeating normal completed-detail -> list -> Settings navigation then passed. Cause and repeatability remain unproven; this observation is not claimed fixed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T04:08:52.467610Z 982fc91 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 982fc912fc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/store/productStore.ts
@dt2patel

dt2patel commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by the consolidated main-targeted PR #745. All standalone fixes, including #750, are included there; fresh Node20/22 build and regression checks pass. Continue review and release QA on #745. Nothing was merged or deployed.

@dt2patel dt2patel closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply timezone changes immediately and redirect other tabs after Receiving logout

1 participant