Repository navigation
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
dt2patel
changed the base branch from
main
to
codex/receiving-standalone-fixes
October 3, 2026 04:04
# Conflicts: # src/store/productStore.ts
…ving-release-performance-qa # Conflicts: # src/store/userStartup.spec.ts
dt2patel
changed the base branch from
codex/receiving-standalone-fixes
to
main
October 8, 2026 19:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store teams must be able to receive the contents of a selected box, save partial progress, complete later receipts, and trust the quantity and time shown across sessions. This consolidates the Receiving fixes and startup improvements into one PR against main, including the return status/list fixes and a reproducible shared-wrapper build contract.
69dc97e9988d35e0c0e87f4091a17360d3d5de13in release, merge-build and PR build paths. The PR and merge workflows own the checkout steps because the existing shared workflows cannot accept a wrapper ref. No shared source is copied into the app. No merge or deployment is performed by this PR update.Closes #750. Tracks #749: linked return inventory reconciliation fails and approval-before-receipt remains blocked; no frontend stock workaround has been introduced. Includes all commits from superseded PR #746.
Validation:
2e55d0397f4be0e9255c3d65e9249e4faf1f18ce, with clean dependency installation, production build and 86 unit tests: https://github.com/hotwax/receiving/actions/runs/37834820082Release remains NO-GO for unrestricted Gorjana rollout. Complete linked return fixture QAR261008RET (sales order, ReturnHeader/Items and ReturnItemShipment links) becomes Received with3/2 accepted, but QOH75/47 remains75/47 rather than78/49; shipment inventory history is empty. Separate valid M100409 approval returns400 and remainsRequested before receipt. Live transitions permit RETURN_ACCEPTED while local approval source requests RETURN_APPROVED; exact deployed cause is unproven. See issue749 validation. No frontend stock workaround. Further compiled Browser check: Shipped P10 is offered receiving but the actual POST400 explicitly rejects PURCH_SHIP_SHIPPED (readback0 accepted); Created P09 POST200 body{} becomesReceived/accepted1 without QOH increase75->76. Actual requests use BROOKLYN. Additional contract validation.
Physical iPad/HID/camera/POS, restricted roles/facility denial, exact Gorjana receiving preferences, external Shopify/NetSuite results and installed-PWA upgrade remain unverified. Earlier route-content mismatch was not reproduced in three final compiled repetitions. Fresh fixture-time shipment metadata needed reload; cause/steady-state repeatability unproven. Combined QA evidence is32 Pass/1 Fail/13 Partial/6 Blocked, with inherited main and fresh candidate results distinguished. This is not blanket certification of every Gorjana flow.