Repository navigation
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing the shared
commonUtilobject loads CSV, Japanese encoding and cron libraries even when an app only needs authentication or display helpers. Split these utilities into focused modules, migrate shared consumers and Shopify auth screens to named imports, and retain the legacy exports for existing apps. The extraction preserves all 63 utility declarations and 57 legacy API keys.Defer Firebase messaging, the API cache adapter, federation and image-preview code until used. Start Shopify login at view-will-enter without the redundant blocking overlay, read POS context/token concurrently, and recheck queued automatic sync work so a slow successful refresh is not immediately repeated. Manual refresh, failure retry and facility isolation remain covered by regression cases. Import guidance is in docs/ACCXUI_IMPORTS.md.
CI also needed two existing integration mismatches corrected: check out
hotwax/inventory-countasapps/cycle-count, matching its package and lockfile entry, and align Order Manager's Dexie lock entry with its already-declared catalog version. No app manifest or installed local dependency was changed; frozen-lockfile validation remains enabled.Validation at
69dc97e:c91b85dproduced 297 passed / the same six failures. The failures concern localhost URL handling, invalid-version comparison, product-feature normalization and a Solr query assertion. All 17 added cases pass. Command:pnpm exec vitest run --config vitest.common.config.ts.Combined Receiving/AccxUI measurements remain in startup measurements and performance audit: initial JavaScript 2.82 MB → 1.70 MB, and prior compiled iPad iframe-to-interactive warm median 2.149 → 1.877 seconds. These gains are from the paired changes, not this shared PR alone. The CI-only follow-up does not change tested runtime source.
Receiving #746 is independent and can merge without this PR. Receiving #745 requires this PR's focused modules; merge this before that follow-up, then rerun Receiving CI. Aditya is handling approvals. No merge or deployment has been performed.
Residual coverage: physical POS was not rerun during the split; earlier device evidence is in the linked audit. Native scanner capture, notification delivery and federation are not fully validated across apps. Existing logout response parsing and Ionic segment console errors remain; compiled localhost logout also has the existing production cookie-domain limitation. These are documented limits, not green end-to-end claims.