chore(ci): add build-tests + lint gating, fix ast.Str deprecation (B1.1, B1.4)#210
chore(ci): add build-tests + lint gating, fix ast.Str deprecation (B1.1, B1.4)#210JarbasAl wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A new update is available for your PR checks! 📥I've aggregated the results of the automated checks for this PR below. 🔍 LintHere's the latest update from the automation pipeline. 🏗️ ❌ ruff: issues found — see job log 🔨 Build TestsEnsuring the gears are properly lubricated. 💧 ✅ All versions pass
The automation never sleeps, but I might reboot. 💤 |
…(B1.1, B1.4) No test suite was ever run in CI - pytest execution and ruff linting are now wired via the shared gh-automations reusable workflows (build-tests.yml, lint.yml), matching org convention. Python matrix includes 3.14, which requires the ast.Str fix below. ast.Str was removed outright in Python 3.12+ (not just deprecated) - ast_analyzer.py:300's isinstance(arg, (ast.Constant, ast.Str)) check would raise AttributeError at class-body evaluation time on any Python where ast.Str no longer exists. Replaced with isinstance(arg, ast.Constant) and isinstance(arg.value, str). Verified clean (no DeprecationWarning, no AttributeError) against a real Python 3.14.6 install. Also installed the declared-but-missing language_data dependency into the shared ovos venv, fixing 4 pre-existing test failures unrelated to this change (169/169 -> confirmed passing before this commit). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JarbasAl
force-pushed
the
feat/ci-and-kabyle
branch
from
6ad96f8 to
65d30d1
Compare
1 participant
Adds CI test gating via gh-automations (build-tests + lint) and fixes an
ast.Strusage that crashes on Python 3.14 (ast.Strwas removed, not just deprecated), so the new py3.14 matrix row goes green.One change, 3 files:
.github/workflows/unit_tests.yml,ovos_localize/analyzers/ast_analyzer.py, and its regression test.Rebuilt off
origin/dev; previously carried ~28 unrelated files.Local:
pytest test/unittests/test_ast_analyzer.py→ 14 passed.