Skip to content

chore(lint): ruff config + mechanical autofixes#217

Open
JarbasAl wants to merge 2 commits into
devfrom
chore/lint-config
Open

chore(lint): ruff config + mechanical autofixes#217
JarbasAl wants to merge 2 commits into
devfrom
chore/lint-config

Conversation

@JarbasAl

Copy link
Copy Markdown
Member

Adds a [tool.ruff] config (E, F, I, UP; line-length 120) so the lint CI job (#210) actually enforces something, plus the one-time mechanical cleanup to make it green.

Two commits:

  1. ruff config only.
  2. autofixes: import sorting, PEP 585/604 typing modernization, remove 3 dead locals, rename 1 ambiguous variable, 2 noqa on long string literals. No behavior change.

Generated data/ and the single-file index.html SPA are excluded from linting.

⚠️ Merge ordering: this is a repo-wide sweep, so it overlaps files in #211 (github.py) and #214 (lang_utils.py). Land it first and rebase those, or land it last — either way the conflicts are mechanical.

Local: ruff check clean; full pytest test/ → 169 passed.

JarbasAl added 2 commits July 11, 2026 01:35
Mechanical: import sorting, PEP 585/604 typing modernization (List/Dict/Optional
-> builtins and X | Y), remove dead locals, rename an ambiguous variable, and
two noqa on long string literals. No behavior change.
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@JarbasAl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 116428ed-5419-4274-a2e8-be4628dfcd85

📥 Commits

Reviewing files that changed from the base of the PR and between 5dc8e63 and 2b760a2.

📒 Files selected for processing (37)
  • ovos_localize/analyzers/__init__.py
  • ovos_localize/analyzers/ast_analyzer.py
  • ovos_localize/analyzers/context_builder.py
  • ovos_localize/bracket_expansion.py
  • ovos_localize/cli/validate.py
  • ovos_localize/datasets/__init__.py
  • ovos_localize/datasets/classification.py
  • ovos_localize/datasets/response_pairs.py
  • ovos_localize/datasets/skill_metadata.py
  • ovos_localize/datasets/slot_filling.py
  • ovos_localize/datasets/translation.py
  • ovos_localize/datasets/tts_corpus.py
  • ovos_localize/lang_utils.py
  • ovos_localize/parsers/__init__.py
  • ovos_localize/parsers/base.py
  • ovos_localize/parsers/dialog.py
  • ovos_localize/parsers/entity.py
  • ovos_localize/parsers/intent.py
  • ovos_localize/parsers/regex.py
  • ovos_localize/parsers/resource_json.py
  • ovos_localize/parsers/settings_meta.py
  • ovos_localize/parsers/skill_json.py
  • ovos_localize/parsers/value.py
  • ovos_localize/parsers/vocab.py
  • ovos_localize/sync/github.py
  • ovos_localize/validators/__init__.py
  • ovos_localize/validators/rules.py
  • pyproject.toml
  • test/unittests/test_ast_analyzer.py
  • test/unittests/test_bracket_expansion.py
  • test/unittests/test_context_builder.py
  • test/unittests/test_datasets.py
  • test/unittests/test_generate_data.py
  • test/unittests/test_lang_utils.py
  • test/unittests/test_parsers.py
  • test/unittests/test_scanner.py
  • test/unittests/test_validators.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/lint-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JarbasAl JarbasAl marked this pull request as ready for review July 11, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant