Repository navigation
Tests: per-directory canonical sidecars and unwritable folders - #99
Conversation
Stubs accept the processed_folder keyword; new tests are skipped until the matching source is available. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Independent reviewVerdict: pass with one should-fix. Full review, own commits 0194599 and 5910c93.
Runs: vs master 484 passed / 14 skipped; vs #97 484 / 14. Against #101 it needs #102's shared-name namespace (expected). Mutations on #101 source (tests from #102 head):
Nothing found for: weak assertions (the unwritable-folder test uses a real filesystem failure and checks no export, no attach, direct packaging and the warning). 🤖 Generated with Claude Code |
The four tests skipped when a log message was reworded. Gate on the processed_folder keyword / move_canonical_marker call the feature adds so a reworded message fails. Drop a redundant guard assignment and an unused tmp_path parameter. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Resolved in a275eba: the four sidecar tests are gated on the 🤖 Generated with Claude Code |
Harness update for #95 (refs #94).
Stubs for the sidecar helpers accept the new
processed_folderkeyword (lambda path, **_kwargs) and the namespace getsPROCESSED_DATA_FOLDER; still passes against the currentmastersource.New tests, skipped until the matching source exists:
_write_canonical_markerrewrites a legacy-only store through the importer;upgrade_reused_canonicalsurvives an unwritable sidecar folder with a WARNING.Verified: current
mastersource 46 passed / 2 skipped; the Migration script: move canonical sidecars via importer helpers #95 branch 48 passed; full harness against Migration script: move canonical sidecars via importer helpers #95 480 passed / 11 skipped; the new tests fail when the corresponding source change is reverted.test-suite(3185bf4, Tests: SSH recovery harness follows the one-path core contract #92) is merged into this branch.New: parametrised Image/Plate
save_as_zarrtests with a real unwritable.processed(asserts no canonical source, noattach_*, no export subprocess, Zarr packaged directly, warning logged);upgrade_reused_canonicalsurvives a corrupt sidecar, an unreadable folder and a nameless path; a failed sidecar move renames the store back. Stubs for the sidecar helpers acceptprocessed_folder, and namespaces definePROCESSED_DATA_FOLDER.Mutations verified: narrowing the load catch, removing the indexing handler, and neutralising the rollback each fail a test.
Results: current
master464 passed / 33 skipped; Migration script: move canonical sidecars via importer helpers #95 branch 485 passed / 12 skipped.Merge together with #95, not before.
Merge order (production and test PRs, interleaved)
Each step keeps
masterCI green: every (production state, test-suite state) pair on this path was run locally with core 2.9.0b26 from PyPI (482, 484, 484, 513, 524, 588, 594, 597, 606 passed; no failures). The production PRs merge cleanly in this order: each branch already contains the conflict resolutions with the PRs before it.test-suite:biomero>=2.9.0b26,<3intests/requirements.txt, so core-dependent tests run in CI)masterand for the new source) (this PR)masterbefore Remove the input marker from results after import on every path #97, by design)A production PR's own check stays red until the test PRs before it in this list are merged (CI runs the shared harness from
test-suite, which is not pinned); merge the test PR, then rerun the check.🤖 Generated with Claude Code