Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ants Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ants-tests test_ssh_recovery.py: #91 passes core's real constants to the pipeline namespace, so the bare-namespace output names of this PR are not needed there. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Independent reviewVerdict: pass. Full review, paired with production PR #97 (8d6ed48).
Runs: vs #97 511 passed / 9 skipped. Vs master the 29 tests of this file fail by design until #97 merges (no other file fails). Vs #101 needs #102 first. Mutations on #97 source:
Nothing found for: silent skips; flag states (shallow off, importer off, both off, empty and missing output) are covered with exact log levels. 🤖 Generated with Claude Code |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The sweep and get_workflow_results_path honour ANALYZED_DATA_FOLDER, the search stops at the stores, and the test no longer keeps its own copies of the folder name, Zarr root files or marker name. Deduplicate the import environment setup and the result-path table; require core 2.9.0b27. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Independent reviewReviewed head a657704 (full re-review) against the #97 source dfc2243, with core from Verdict: approve after two should-fix items (one test each). No blocking findings. Results
Findings
Nothing found for: tests that restate the implementation or assert on their own mocks; the fake layout ( Mutation checks (scratch copy of #97 source, targeted files)Killed: sweep compares to a literal 🤖 Generated with Claude Code |
…rals Test that the retry lookup reads ANALYZED_DATA_FOLDER and that no script hardcodes the default name (which also covers the finalize lock folder). Share the env-clearing fixture in conftest.py; wrap a long line. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Resolved in c7595d0: 🤖 Generated with Claude Code |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… sweep The result folder is no longer configurable in 1.8 (NL-BIOMERO#111): the sweep refuses a Results_Path of another workflow and accepts what the import makes, and only SLURM_Import_Results.py names the folder, once. Core floor is b26 again. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The retry-lookup tests exec find_existing_result_storage in a bare namespace. Source that defines the RESULTS_FOLDER constant needs it there; source that does not (master) is unaffected. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…-after-import Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rness branch Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Independent reviewReviewer: independent agent. Head d24ff0a (contains #104) against #97 1133f5b. Verdict: approve. No blocking. 1 should fix (small test gap), 3 nits.
Mutation checks (scratch copy of #97 source; tests = this file plus
Other checks
🤖 Generated with Claude Code |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ing and a real UUID Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…hallow-storage flag Bare-namespace tests of the runner and image transfer now also provide constants.results.CANONICAL_INPUTS_OUTPUT and SHALLOW_ZARR_STORAGE_ENABLED, and the transfer output test accepts the core constant. Source that defines the name or the expression locally (master) is unaffected. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…arker-after-import Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…_ENABLED Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…arker-after-import Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Resolved in 41f6833: 🤖 Generated with Claude Code |
Independent review (follow-up)Reviewed the delta d24ff0a..41f6833: the new commit b83c547 plus merges of Verdict: approve. No blocking or should-fix findings; 1 nit. Checked
Mutation checks (scratch copy of the #97 source)
Findings
None found for the other rule categories (test-only PR). Needs a real stackUnchanged from the previous review. 🤖 Generated with Claude Code |
Tests for #96 (production change: PR for branch
fix/remove-input-marker-after-importonmaster; merge that one first, because these tests fail on currentmasterby design).tests/test_input_marker_cleanup.py:importResultsToOmerowith a fake import script that asserts the marker still exists when the importer runs, so cleanup before the import fails.Results_Pathcame back, marker stays when the import fails.<result folder>/<wf>are refused, a result folder linked to user data is refused (skipped where links cannot be created), links are not followed, an unreadable folder warns, and a failing cleanup does not fail the import.Results_Pathwhose parent folder is not this run's workflow id and accepts the path the import makes; onlySLURM_Import_Results.pycontains the literal.analyzed, exactly once (AST test); the retry lookup is tested.TRANSFER_INPUT_MARKERofbiomero_schema.zarrand core's constants instead of its own copies; the shared import environment is one helper and the result-path table has one row per distinct path.test_import_retry_storage.pygives its bare namespaceread_analyzed_data_folder.Results_Pathoutput.Checked red/green on scratch copies: all fail on unchanged
master; cleanup call removed, cleanup before the import,realpathtoabspath,followlinks=True, a looser folder check, notryaround the call, noonerror, and a second.analyzedliteral, removing the workflow-id check and removing the depth limit each make at least one test fail. Full harness against #97 locally (core 2.9.0b26 from PyPI): 518 passed, 35 skipped; againstmaster, only this file's tests fail.Merge order (production and test PRs, interleaved)
Each step keeps
masterCI green: every (production state, test-suite state) pair on this path was run locally with core 2.9.0b26 from PyPI (482, 484, 484, 513, 524, 588, 594, 597, 606 passed; no failures). The production PRs merge cleanly in this order: each branch already contains the conflict resolutions with the PRs before it.test-suite:biomero>=2.9.0b26,<3intests/requirements.txt, so core-dependent tests run in CI)masterand for the new source)test-suite: the retry-lookup tests know theRESULTS_FOLDERconstant; the harness namespaces know core'sCanonical_Inputsname and the shallow-storage flag; without them Remove the input marker from results after import on every path #97's CI fails withNameError)masterbefore Remove the input marker from results after import on every path #97, by design) (this PR)A production PR's own check stays red until the test PRs before it in this list are merged (CI runs the shared harness from
test-suite, which is not pinned); merge the test PR, then rerun the check.🤖 Generated with Claude Code
Second review round: the guarded
biomero_schema.zarrimport and its constant are pinned against the file name the tests use (the transfer-marker test uses the constant too), importer off / shallow off / both off and an emptyResults_Pathare covered, a../escape path is refused, fake outputs use an rstring-like object, and the textual contract is commented.test-suiteis merged in.Core:
tests/requirements.txtneedsbiomero>=2.9.0b26,<3. The tests inject the constants for the run script; the contract test checks that both scripts use the core constant and define none locally.