Repository navigation
Conversation
…e runner Capability-gated: they follow the source revision that imports biomero_schema.zarr and biomero.metadata_views, and skip or fall back for older revisions. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Capability-gated: skipped until the source owns decide_workflow_resume and core has WorkflowTracker.add_launcher_task. Existing structural tests accept both the old and the new layout. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…gates Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…I, poll budget Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tes, cancel script on a real tracker Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…pletes; scancel failure message Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Stubs accept the processed_folder keyword; new tests are skipped until the matching source is available. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er, other) Also keeps the structural cancel-handler test, with a comment on why. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ants Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contract test that fails if a script uses an output-name literal instead of biomero.constants.results; existing tests that run script functions in a bare namespace provide the constants. Gated on the source using the constants. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ants-tests test_ssh_recovery.py: #91 passes core's real constants to the pipeline namespace, so the bare-namespace output names of this PR are not needed there. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
- test_shared_output_names.py (renamed from test_script_output_constants.py) flags any string constant equal to one of the four shared names, except docstrings, the "type": "URL" value and the batched runner's UI_messages keys; fails when no scripts are found; only the per-script check is gated. - script_output_names.py reads the values from biomero.constants.results. - test_input_marker_cleanup.py gets the shared names from the same source. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The input marker cleanup (#97) merges before the Zarr contract move (#88) and already imports its marker name from biomero_schema.zarr next to the remaining biomero.zarr_contracts import. Count a script with any old-form import as the old form, so the harness passes for source with and without that cleanup. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
With core installed in CI, they failed on a missing file for the source revisions that predate the detached ownership change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nstants-tests Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…-tests Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Other core constants (such as the results path output) are already read by earlier scripts changes; only the four shared output names mark a revision that has moved to the constants. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Independent reviewVerdict: pass. Full review of its own commits (13b53e3, 0356fa0, 99f13b1 and the merge conflict resolutions); merged #89, #91, #99 and #98 content is reviewed in those PRs. Paired with production PR #101 (9def6e0).
Runs (core 2.9.0b26, one run at a time): vs #101 606 passed / 9 skipped; vs #97 516 passed / 44 skipped; vs master 487 passed / 44 skipped / 29 failed, all 29 in Mutations: a literal Nothing found for: values duplicated from core (names come from 🤖 Generated with Claude Code |
Skip only when the source has no detached batched launcher (or no cancel script); a source with launcher tasks but no register_detached_batches, or a cancel script without runScript, now fails. Note where the processor key pin is updated. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The four tests skipped when a log message was reworded. Gate on the processed_folder keyword / move_canonical_marker call the feature adds so a reworded message fails. Drop a redundant guard assignment and an unused tmp_path parameter. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Resolved in 6acf0e4: 🤖 Generated with Claude Code |
Refs #100 (harness only).
Contract test
tests/test_script_output_constants.py: fails if a script in__workflows/or_data/sets or readsMessage,URL,File_AnnotationorCanonical_Inputswith a string literal instead ofbiomero.constants.results.*_OUTPUT, or defines its own output name. It reads the source only (no core needed) and skips for source revisions that do not use the constants yet; it includes a self-test of the detector. Existing tests that run script functions in a bare namespace now getconstants.resultsfromtests/script_output_names.py; the Canonical_Inputs source check accepts the old and new form.Verified: against the new scripts (PR #101) 493 passed, 8 skipped; against
masterthe new test skips and the touched tests pass; re-introducing a literal in a script fails the contract test.Merge before #101. Remove the old forms after #101 merges.
Merge order (production and test PRs, interleaved)
Each step keeps
masterCI green: every (production state, test-suite state) pair on this path was run locally with core 2.9.0b26 from PyPI (482, 484, 484, 513, 524, 588, 594, 597, 606 passed; no failures). The production PRs merge cleanly in this order: each branch already contains the conflict resolutions with the PRs before it.test-suite:biomero>=2.9.0b26,<3intests/requirements.txt, so core-dependent tests run in CI)masterand for the new source)masterbefore Remove the input marker from results after import on every path #97, by design)A production PR's own check stays red until the test PRs before it in this list are merged (CI runs the shared harness from
test-suite, which is not pinned); merge the test PR, then rerun the check.🤖 Generated with Claude Code
Review fixes and chain
tests/test_shared_output_names.py(renamed fromtest_script_output_constants.py): flags any string constant equal to one of the four names (assignments, annotated assignments, variables, readers), except docstrings, the"type": "URL"value and the batched runner'sUI_messageskeys. It fails when no scripts are found, its self-tests never skip, and only the per-script check is gated (while no script reads one of the four names from core); remove that gate after Use the core script-output constants #101 merges.tests/script_output_names.pybuilds the values frombiomero.constants.results(core is installed by Tests: install biomero core 2.9.0b26 in the harness #103), includingRESULTS_PATH_OUTPUT, so there is no copy to drift.tests/test_ssh_recovery.pywith Tests: detached resume, cancel and registration #91 is resolved by keeping Tests: detached resume, cancel and registration #91's namespace (core's real constants).test_input_marker_cleanup.pytakes the shared names from the same source.