Skip to content

Allow terminal command queueing (in addition to prompt queueing)#12259

Merged
harryalbert merged 9 commits into
masterfrom
harry/support-shell-command-queueing
Jun 9, 2026
Merged

Allow terminal command queueing (in addition to prompt queueing)#12259
harryalbert merged 9 commits into
masterfrom
harry/support-shell-command-queueing

Conversation

@harryalbert

@harryalbert harryalbert commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Description

Right now you can queue prompts, but you can't queue terminal commands. Some folks have requested that you be able to do so (interleaved with prompts), with the next queued item sending when either the previous prompt or command is done.

Linked Issue

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

https://www.loom.com/share/2955a5ce19474e659f5ab178d329428b

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label Jun 5, 2026
@harryalbert harryalbert changed the title write product and tech specs Allow for prompt Jun 5, 2026

harryalbert commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

@harryalbert harryalbert requested review from moirahuang and zachbai June 5, 2026 16:43
@harryalbert harryalbert marked this pull request as ready for review June 5, 2026 16:43
@harryalbert harryalbert changed the title Allow for prompt Allow terminal command queueing (in addition to prompt queueing) Jun 5, 2026
@oz-for-oss

oz-for-oss Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR extends queued prompts so shell commands can be queued and drained in FIFO order across local and shared-session panes, with command rows rendered distinctly and tests covering the new model/input/view paths.

Concerns

  • Shared-session command completion can clear the in-flight flag before the synced block-completion cleanup runs, allowing the later cleanup to wipe the user's draft.
  • A queued command can be removed from the queue and then lost if dispatch fails while the editor already contains draft text.
  • Whitespace-only shell submissions can now be queued as command rows.

Verdict

Found: 0 critical, 2 important, 1 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread app/src/terminal/input.rs
Comment thread app/src/terminal/view.rs Outdated
Comment thread app/src/terminal/input.rs
@harryalbert harryalbert removed the request for review from zachbai June 8, 2026 17:55
@harryalbert harryalbert force-pushed the harry/app-4617-store-message-attachments-in-queued-prompts-clearing branch from 1b257a7 to f69a2fd Compare June 8, 2026 20:56
@harryalbert harryalbert force-pushed the harry/support-shell-command-queueing branch from 88e22a7 to 822fd13 Compare June 8, 2026 20:56
Comment thread app/src/terminal/view/queued_prompts_panel.rs
Comment thread app/src/terminal/input.rs Outdated
Comment thread app/src/ai/blocklist/queued_query_tests.rs
Comment thread app/src/terminal/input.rs Outdated
@harryalbert harryalbert force-pushed the harry/app-4617-store-message-attachments-in-queued-prompts-clearing branch from f69a2fd to bf0c7a0 Compare June 9, 2026 13:49
@harryalbert harryalbert force-pushed the harry/support-shell-command-queueing branch 2 times, most recently from 0afe1c1 to 89f6273 Compare June 9, 2026 15:14
Base automatically changed from harry/app-4617-store-message-attachments-in-queued-prompts-clearing to master June 9, 2026 15:34
@harryalbert harryalbert force-pushed the harry/support-shell-command-queueing branch from 89f6273 to 6a43729 Compare June 9, 2026 15:35
@harryalbert harryalbert force-pushed the harry/support-shell-command-queueing branch from f3fa248 to 62572d3 Compare June 9, 2026 18:20
@harryalbert harryalbert merged commit e367c9d into master Jun 9, 2026
26 checks passed
@harryalbert harryalbert deleted the harry/support-shell-command-queueing branch June 9, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants