Allow terminal command queueing (in addition to prompt queueing)#12259
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR extends queued prompts so shell commands can be queued and drained in FIFO order across local and shared-session panes, with command rows rendered distinctly and tests covering the new model/input/view paths.
Concerns
- Shared-session command completion can clear the in-flight flag before the synced block-completion cleanup runs, allowing the later cleanup to wipe the user's draft.
- A queued command can be removed from the queue and then lost if dispatch fails while the editor already contains draft text.
- Whitespace-only shell submissions can now be queued as command rows.
Verdict
Found: 0 critical, 2 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
1b257a7 to
f69a2fd
Compare
88e22a7 to
822fd13
Compare
f69a2fd to
bf0c7a0
Compare
0afe1c1 to
89f6273
Compare
89f6273 to
6a43729
Compare
f3fa248 to
62572d3
Compare

Description
Right now you can queue prompts, but you can't queue terminal commands. Some folks have requested that you be able to do so (interleaved with prompts), with the next queued item sending when either the previous prompt or command is done.
Linked Issue
ready-to-specorready-to-implement.Auto-queue should support shell command submissions #11912
Testing
./script/runScreenshots / Videos
https://www.loom.com/share/2955a5ce19474e659f5ab178d329428b
Agent Mode