store prompt attachments on queued prompt model, store on prompt queue, attach on submit

[harryalbert]

Description

Before this PR, if you queued a prompt with an image attached, the image would stay attached in the input and not get associated with the prompt/cleared until send time. This isn't great, and is especially untenable if we want to allow users to queue multiple prompts, each with their own attachments.

This PR fixes it so that the queued prompt singleton stores prompt attachments along with the prompt text such that, when the prompt is queued, we can clear the attachments from the input and, when the prompt is sent, we can send the attachments with the prompt.

Testing

• I have manually tested my changes locally with ./script/run

Screenshots / Videos

https://www.loom.com/share/814a8562374a456ead64f409321f1a0b

Agent Mode

• Warp Agent Mode - This PR was created via Warp's AI Agent Mode

[harryalbert]

• Allow terminal command queueing (in addition to prompt queueing) #12259
• store prompt attachments on queued prompt model, store on prompt queue, attach on submit #11901 👈 (View in Graphite)
• Use new queued prompt panel for /compact-and and /fork-and-compact #11575 : 2 other dependent PRs (#11746 , #11880 )
• Use new queued prompt UI for cloud mode #11547
• Create new queued prompts list UI #11439
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[oz-for-oss]

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR moves image/file attachments from live input staging onto queued prompt rows, threads queued row ids through local/slash/skill send paths, and adds tests/specs for the new behavior. The direct local send paths generally resolve row-owned attachments before removal, and I did not find security issues in the changed code.

Concerns

• Queued shared-session viewer prompts can lose their row and attachments if the asynchronous upload path fails before emitting SendAgentPrompt; the row is removed immediately after starting dispatch.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz