RSDK-14415 Authorize user invocations based on user_permissions - #6269
Open
Benjamin Rewis (benjirewis) wants to merge 11 commits into
Open
RSDK-14415 Authorize user invocations based on user_permissions#6269Benjamin Rewis (benjirewis) wants to merge 11 commits into
user_permissions#6269Benjamin Rewis (benjirewis) wants to merge 11 commits into
Conversation
Benjamin Rewis (benjirewis)
force-pushed
the
perms
branch
from
August 12, 2026 21:06
a9344e2 to
04df2fc
Compare
user_permissions
…rmissions changes
| golang.org/x/exp v0.0.0-20260611194520-c48552f49976 | ||
| ) | ||
|
|
||
| replace go.viam.com/api => ../api-gen |
Benjamin Rewis (benjirewis)
marked this pull request as ready for review
August 17, 2026 17:50
Benjamin Rewis (benjirewis)
requested review from
Daniel Botros (danielbotros) and
Josh Matthews (jmatth)
August 17, 2026 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSDK-14415
What
Enforces the
user_permissionssection of a machine's auth config as described in the scope.UserPermission,User, andPermissionstructs to configuserPermsAuthorizer(robot/web/authorization.go) that builds per-user permission tables from the config and enforces them via gRPC unary and stream interceptorsWhen
user_permissionschanges, tears down gRPC and WebRTC streams that are no longer permitted.Why
Motivation from scope:
Enforcement semantics:
user_permissionsis undefined or empty, no client is restricted (today's behavior)defaultuser is defined; unauthenticated clients are always fully restricted; a user with multiple entries is fully restricted and an error is loggedRobotServicemethods,ListStreams) match only grants under the special_machineresources stringTesting
robot/web/authorization_test.goandrobot/impl/user_permissions_e2e_test.go[Description generated by Claude 🤖]