Lint view component best practices - #142
Merged
Merged
Conversation
> A RuboCop extension that encourages ViewComponent best practices: > https://viewcomponent.org/best_practices.html
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The configuration/comment intent for ViewComponent/ComponentSuffix is inconsistent (cop disabled while stating the suffix should be avoided), so the desired enforcement needs to be corrected or clarified before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds rubocop-view_component to the project’s RuboCop configuration to lint ViewComponent code against recommended best practices, integrating it alongside the existing Standard/RuboCop plugin setup.
Changes:
- Added the
rubocop-view_componentgem (and prevented auto-require of linting gems where appropriate). - Enabled the
rubocop-view_componentRuboCop plugin and introduced initial ViewComponent cop configuration overrides.
File summaries
| File | Description |
|---|---|
| Gemfile | Adds rubocop-view_component and adjusts linting gem require behavior. |
| .rubocop.yml | Registers the rubocop-view_component plugin and configures ViewComponent-specific cops. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use rubocop-view_component to verify ViewComponent best practices.