Add Flowbite Components verification - #67
Merged
Merged
Conversation
Owner
Author
|
cc @koppen in case you might be interested in adding this as a check your gem. |
|
Interesting... we're not exactly following best practices, though 🙈 |
Owner
Author
|
You actually are in most places, the only things the linting picked up on were the missing You get full marks for the rest:
|
Owner
Author
|
Actually, there are a couple of bugs this has highlighted. Looking into... |
I am happy to provide some edge cases for you to battle 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds substancelab/flowbite-components as a verification target. Includes its RuboCop configuration, generated expected offenses, and ignores the downloaded source directory.