Skip to content

Add Flowbite Components verification - #67

Merged
andyw8 merged 4 commits into
mainfrom
andyw8/add-flowbite-verification
Aug 28, 2026
Merged

andyw8 merged 4 commits into
mainfrom
andyw8/add-flowbite-verification

Conversation

@andyw8

@andyw8 andyw8 commented Aug 28, 2026

Copy link
Copy Markdown
Owner

Adds substancelab/flowbite-components as a verification target. Includes its RuboCop configuration, generated expected offenses, and ignores the downloaded source directory.

@andyw8
andyw8 merged commit 8f59534 into main Aug 28, 2026
6 checks passed
@andyw8

andyw8 commented Aug 28, 2026

Copy link
Copy Markdown
Owner Author

cc @koppen in case you might be interested in adding this as a check your gem.

@koppen

koppen commented Aug 31, 2026

Copy link
Copy Markdown

Interesting... we're not exactly following best practices, though 🙈

@andyw8

andyw8 commented Aug 31, 2026

Copy link
Copy Markdown
Owner Author

You actually are in most places, the only things the linting picked up on were the missing -Component extensions and some methods which could be private.

You get full marks for the rest:

  • ViewComponent/NoGlobalState - Prevent direct access to params, request, session, etc.
  • ViewComponent/PreferSlots - Detect HTML parameters that should be slots
  • ViewComponent/PreferComposition - Avoid inheriting one ViewComponent from another (prefer composition)
  • ViewComponent/TestRenderedOutput - Encourage testing rendered output over private methods
  • ViewComponent/MissingPreview - Ensure every ViewComponent has a corresponding preview file

@andyw8

andyw8 commented Aug 31, 2026

Copy link
Copy Markdown
Owner Author

Actually, there are a couple of bugs this has highlighted. Looking into...

@koppen

koppen commented Sep 3, 2026

Copy link
Copy Markdown

@koppen

koppen commented Sep 3, 2026

Copy link
Copy Markdown

Actually, there are a couple of bugs this has highlighted. Look into...

I am happy to provide some edge cases for you to battle 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants