Repository navigation
Pass K8S_VERSION and TIMEOUT as make arguments to deploy action - #2702
Merged
Merged
Conversation
K8S_VERSION and TIMEOUT must be passed as make command-line arguments rather than environment variables, since they are not in DAPPER_ENV and won't be forwarded into the Dapper container where deployment actually runs. Add a timeout input parameter to the deploy action and update testing.yml to use it. This ensures both K8S_VERSION and TIMEOUT reach the Make invocation inside Dapper via MAKEFLAGS. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
tpantelis
requested review from
Oats87,
mkolesnik,
skitt and
sridhargaddam
as code owners
November 2, 2026 13:24
|
🤖 Created branch: z_pr2702/tpantelis/fix-deploy |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 2, 2026
|
🤖 Closed branches: [z_pr2702/tpantelis/fix-deploy] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
K8S_VERSION and TIMEOUT must be passed as make command-line arguments rather than environment variables, since they are not in DAPPER_ENV and won't be forwarded into the Dapper container where deployment actually runs.
Add a timeout input parameter to the deploy action and update testing.yml to use it. This ensures both K8S_VERSION and TIMEOUT reach the Make invocation inside Dapper via MAKEFLAGS.