Skip to content

Automated backport of #2702: Pass K8S_VERSION and TIMEOUT as make arguments to deploy - #2707

Merged
tpantelis merged 1 commit into
submariner-io:release-0.20from
tpantelis:automated-backport-of-#2702-upstream-release-0.20
Nov 2, 2026
Merged

tpantelis merged 1 commit into
submariner-io:release-0.20from
tpantelis:automated-backport-of-#2702-upstream-release-0.20

Conversation

@tpantelis

Copy link
Copy Markdown
Contributor

Backport of #2702 on release-0.20.

#2702: Pass K8S_VERSION and TIMEOUT as make arguments to deploy

For details on the backport process, see the backport requests page.

K8S_VERSION and TIMEOUT must be passed as make command-line
arguments rather than environment variables, since they are not
in DAPPER_ENV and won't be forwarded into the Dapper container
where deployment actually runs.

Add a timeout input parameter to the deploy action and update
testing.yml to use it. This ensures both K8S_VERSION and TIMEOUT
reach the Make invocation inside Dapper via MAKEFLAGS.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@submariner-bot

Copy link
Copy Markdown

🤖 Created branch: z_pr2707/tpantelis/automated-backport-of-#2702-upstream-release-0.20

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1ab06d72-83a4-44df-b28f-9825eb0efb16
Commits

Reviewing files that changed from the base of the PR and between eea26d6 and 1b56e0b.

Files selected for processing: 2
  • .github/workflows/testing.yml
  • gh-actions/deploy/action.yaml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@tpantelis

Copy link
Copy Markdown
Contributor Author

@coderabbitai approve

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown
Action performed

Comments resolved and changes approved.

@tpantelis
tpantelis merged commit 1a65da0 into submariner-io:release-0.20 Nov 2, 2026
47 of 50 checks passed
@submariner-bot

Copy link
Copy Markdown

🤖 Closed branches: [z_pr2707/tpantelis/automated-backport-of-#2702-upstream-release-0.20]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants