fix(examples): silentpaymentscanner.rs:arg parsing#199
Merged
Conversation
Contributor
Author
|
note: the binary itself is the first arg - therefore less than 2 better reflects the intent. 
|
RandyMcMillan
force-pushed
the
955671/1865/248947/f8ea599/19d25f8-examples-src/silentpaymentscanner.rs
branch
from
d747c1a to
8174a81
Compare
alexanderwiederin
left a comment
alexanderwiederin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this!
Could you please update the commit message to follow these git commit guidelines?
| ## [Unreleased] | ||
|
|
||
| ### Added | ||
| - Updated examples/src/silentpaymentscanner.rs:if args.len() < 2 |
Collaborator
There was a problem hiding this comment.
No CHANGELOG entry needed - this change does not affect the public API.
I have added the no-changelog label, so the PR check test won't run anymore.
alexanderwiederin
added
the
no-changelog
RandyMcMillan
force-pushed
the
955671/1865/248947/f8ea599/19d25f8-examples-src/silentpaymentscanner.rs
branch
from
8174a81 to
98fac8d
Compare
RandyMcMillan
changed the title
Contributor
Author
RandyMcMillan
force-pushed
the
955671/1865/248947/f8ea599/19d25f8-examples-src/silentpaymentscanner.rs
branch
from
98fac8d to
ea129ff
Compare
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.