chore(ci): examples:cargo run#200
Conversation
|
follow up to #199 (combined) |
RandyMcMillan
force-pushed
the
955676/1865/241798/19d25f8/8174a81-example-ci-cargo-run
branch
from
e8d1bd9 to
b93183c
Compare
| - name: Run tests | ||
| run: cargo test -vv | ||
| - name: Build and Test | ||
| env: |
There was a problem hiding this comment.
fixes an intermittent failure:
CARGO_HTTP_PROTOCOL: "http1": HTTP/2 is prone to framing layer errors when proxies or unstable networks are involved in CI runners. HTTP/1.1 is significantly more resilient for the small, numerous requests required by cargo.
CARGO_HTTP_MULTIPLEXING: "false": This disables the ability to send multiple requests over one connection, which is exactly where the "HTTP2 framing layer" errors usually manifest during concurrent dependency downloads.
CARGO_NET_RETRY: Increases the patience of the Cargo client if a transient packet loss occurs during the is_terminal_polyfill download.
alexanderwiederin
left a comment
alexanderwiederin
left a comment
There was a problem hiding this comment.
Thanks for the suggestions!
| run: | | ||
| cd examples | ||
| cargo build --verbose | ||
| cargo run --verbose -- datadir |
There was a problem hiding this comment.
This runs silentpaymentscanner.rs against an empty datadir, so scan_chain will iterate over an empty chain. Does this test anything beyond "the binary doesn't crash on startup"?
There was a problem hiding this comment.
you are correct - please suggest a better implementation.
maybe the simple arg test (above) - then maybe no arg (default) to test default?
There was a problem hiding this comment.
I am not sure I understand what you are trying to achieve. I don't think the examples are intended to be run in the CI to check that they run without panicking, but more for people to see what the API looks like in use. What do you think?
| run: | | ||
| # Clean the stale/corrupted attempt | ||
| cargo clean | ||
| # Force an update of the registry without using multiplexing | ||
| cargo update | ||
| # Perform the test | ||
| cargo test -vv |
There was a problem hiding this comment.
Is this test really a problem? I do not recall seeing a flaky windows run.
There was a problem hiding this comment.
the flakiness may be due to GitHub infrastructure - not necessarily from the implementation.
RandyMcMillan
force-pushed
the
955676/1865/241798/19d25f8/8174a81-example-ci-cargo-run
branch
from
b93183c to
b3eafcd
Compare
RandyMcMillan
changed the title
RandyMcMillan
force-pushed
the
955676/1865/241798/19d25f8/8174a81-example-ci-cargo-run
branch
from
b3eafcd to
bfc51be
Compare
RandyMcMillan
changed the title
2 participants
No description provided.