Skip to content

Refactored docs for std::fs::set_permissions_nofollow + fix BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW flag - #160170

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
asder8215:docs_set_perms_nofollow
Aug 30, 2026
Merged

Refactored docs for std::fs::set_permissions_nofollow + fix BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW flag#160170
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
asder8215:docs_set_perms_nofollow

Conversation

@asder8215

@asder8215 asder8215 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

View all comments

Original Tracking Issue: #141607
Fixes mistake made in #158168

This PR refactors documentations for std::fs::set_permissions_nofollow and fixes BSD-based systems + Android to use fchmodat with AT_SYMLINK_NOFOLLOW flag (instead of no flag set) and refactors all other platforms to defer to OpenOptions with O_NOFOLLOW behavior.

r? @clarfonthey
Since they looked at the original set_permissions_nofollow PR I made

cc @RalfJung

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 29, 2026
Comment thread library/std/src/fs.rs Outdated
@clarfonthey

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d24bee2 has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2026
Comment thread library/std/src/fs.rs Outdated
@RalfJung

Copy link
Copy Markdown
Member

@bors r-

Sorry I have a question :)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 29, 2026
@rust-bors

rust-bors Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

View changes since this unapproval

@clarfonthey

Copy link
Copy Markdown
Contributor

r? RalfJung since you're mostly reviewing already

@rustbot

rustbot commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

RalfJung is not on the review rotation at the moment.
They may take a while to respond.

@asder8215
asder8215 force-pushed the docs_set_perms_nofollow branch from d24bee2 to 82ff1cb Compare July 29, 2026 21:45
@asder8215
asder8215 requested a review from RalfJung July 29, 2026 21:46
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 29, 2026
@asder8215 asder8215 changed the title Refactored docs for std::fs::set_permissions_nofollow clarifying BSD-based platforms behavior Refactored docs for std::fs::set_permissions_nofollow + fix BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW flag Jul 29, 2026
@asder8215
asder8215 force-pushed the docs_set_perms_nofollow branch from 82ff1cb to f0403c2 Compare July 29, 2026 21:49
Comment thread library/std/src/fs/tests.rs Outdated
Comment thread library/std/src/fs/tests.rs Outdated
Comment thread library/std/src/sys/fs/unix.rs Outdated
Comment thread library/std/src/sys/fs/unix.rs Outdated
Comment thread library/std/src/fs.rs Outdated
@RalfJung

Copy link
Copy Markdown
Member

The user-facing comments are fine but this is turning into a libs discussion about the implementation.

r? libs

@rust-bors

rust-bors Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 5d829d9 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@asder8215

Copy link
Copy Markdown
Contributor Author

This latest commit builds with the command Ralf suggested me to use (and dist-android worked before as well), so I don't think I should worry about running dist-android. The test failures were as a result of the two tests expecting set_permissions_nofollow to work on regular files, but since we have Android returning an error always, those tests will always fail; I just have it adjusted so that those tests don't run on Android. Just to make sure, I'll do one last try job on android to see if everything's alright.
@bors try jobs=arm-android

@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 67df177 (67df177ab57f719021bc95ce2796aea81de98710)
Base parent: d9dd070 (d9dd0703ba332dbdd19ae6c9bf7ab98ab7c933c7)

@clarfonthey

Copy link
Copy Markdown
Contributor

Will do an extra review later and hopefully after we can merge 🤞🏻

Comment on lines +1887 to +1897
#[cfg(target_os = "android")]
pub fn set_perm_nofollow(_p: &CStr, _perm: FilePermissions) -> io::Result<()> {
// Currently Android seems to be having inconsistent behavior with fchmodat
// with `AT_SYMLINK_NOFOLLOW` or openat with `O_NOFOLLOW` + fchmod.
// See this issue here mentioning inconsistent behavior on fchmodat:
// https://github.com/android/ndk/issues/1258
// On the arm-android CI job, using fchmodat with `AT_SYMLINK_NOFOLLOW` +
// fallback behavior on a symlink sets the target file's permissions,
// which is incorrect behavior.
Err(crate::io::ErrorKind::Unsupported.into())
}

@Darksonn Darksonn Aug 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have an open issue to track this not working on Android? And/or tracking making it work on SDK levels where it's not broken?

View changes since the review

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should have such an issue.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note to the tracking issue, since this is unstable.

@clarfonthey

Copy link
Copy Markdown
Contributor

Yeah, a bit concerned about the Android issues, although I'm going to attempt to try and merge this now since it is a strict improvement.

@bors r+ rollup=iffy note="Failed a handful of times, should hopefully pass this time"

@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c7b10b4 has been approved by clarfonthey

It is now in the queue for this repository.

@JonathanBrouwer

Copy link
Copy Markdown
Member

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #161949 (comment)

@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#161949), which was unapproved.

View changes since this unapproval

Comment thread library/std/src/fs/tests.rs Outdated

@asder8215 asder8215 Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I should use symlink_file for this test instead of symlink_dir (since the link goes to a file and not a directory). I didn't realize there was a separate function for that on Windows.

View changes since the review

…d fchmodat platform call on fchmodat and every platform falls back to open + fchmod when _res is set to ErrorKind::Unsupported; updated docs to reflect change
@asder8215

Copy link
Copy Markdown
Contributor Author

This should hopefully work with symlink_file on Windows instead of symlink_dir

@bors try jobs=x86_64-msvc-1

@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: eb0b681 (eb0b681f59753aaf4b7df4b3b999652faefa8ae5)
Base parent: 17fd5b8 (17fd5b8a37b6667b6cc137f3cc35f09759768a3b)

@asder8215

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@clarfonthey

Copy link
Copy Markdown
Contributor

Uhhh

@bors try jobs=various,android,dist-x86_64-linux-quick

Just to be safe

@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 027913f (027913f36ea684e0e25ed7a825c76711f545c594)
Base parent: fd7ed57 (fd7ed57dfd3bdebb745a1d8158638727b0e7047a)

@clarfonthey

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b901613 has been approved by clarfonthey

It is now in the queue for this repository.

@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

💔 Test for d608d6b failed: CI. Failed job:

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling unicode-ident v1.0.24
   Compiling serde_core v1.0.229
error: linking with `cc` failed: exit status: 71
  |
  = note:  "cc" "/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/build/proc-macro2-4417142953ca1d09/rustckS3ipT/symbols.o" "<2 object files omitted>" "<sysroot>/lib/rustlib/aarch64-apple-darwin/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-lSystem" "-lc" "-lm" "-arch" "arm64" "-mmacosx-version-min=11.0.0" "-o" "/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/build/proc-macro2-4417142953ca1d09/build_script_build-4417142953ca1d09" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: dyld[69548]: Library not loaded: /System/Library/PrivateFrameworks/AppleKeyStore.framework/Versions/A/AppleKeyStore
            Referenced from: <DE0D8141-40A2-3E24-A766-DAC36ABFC0B1> /System/Library/Frameworks/Security.framework/Versions/A/Security
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/CollectionsInternal.framework/Versions/A/CollectionsInternal
            Referenced from: <D25E0345-D6C1-3FAB-94EF-71753EC63659> /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/BiomeLibrary.framework/Versions/A/BiomeLibrary
            Referenced from: <EB538E77-842B-3181-A7E4-D6E4869016D9> /System/Library/PrivateFrameworks/DuetActivityScheduler.framework/Versions/A/DuetActivityScheduler
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/CollectionsInternal.framework/Versions/A/CollectionsInternal
            Referenced from: <6CD7E451-8913-338E-AA36-52C55D53883F> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/CollectionViewCore.framework/Versions/A/CollectionViewCore
            Referenced from: <33D86ABE-3911-31E8-8574-72D3319C0EE4> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/proc-macro2-1.0.107/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)
          cc: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!
          cc: error: You can set the path to the Xcode folder using /usr/bin/xcode-select -switch
          

error: linking with `cc` failed: exit status: 71
  |
  = note:  "cc" "/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/build/serde_core-923d5bcb85e44581/rustcZCOVAw/symbols.o" "<2 object files omitted>" "<sysroot>/lib/rustlib/aarch64-apple-darwin/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-lSystem" "-lc" "-lm" "-arch" "arm64" "-mmacosx-version-min=11.0.0" "-o" "/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/build/serde_core-923d5bcb85e44581/build_script_build-923d5bcb85e44581" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: dyld[69547]: Library not loaded: /System/Library/PrivateFrameworks/AppleKeyStore.framework/Versions/A/AppleKeyStore
            Referenced from: <DE0D8141-40A2-3E24-A766-DAC36ABFC0B1> /System/Library/Frameworks/Security.framework/Versions/A/Security
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/CollectionsInternal.framework/Versions/A/CollectionsInternal
            Referenced from: <D25E0345-D6C1-3FAB-94EF-71753EC63659> /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/BiomeLibrary.framework/Versions/A/BiomeLibrary
            Referenced from: <EB538E77-842B-3181-A7E4-D6E4869016D9> /System/Library/PrivateFrameworks/DuetActivityScheduler.framework/Versions/A/DuetActivityScheduler
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/CollectionsInternal.framework/Versions/A/CollectionsInternal
            Referenced from: <6CD7E451-8913-338E-AA36-52C55D53883F> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/CollectionViewCore.framework/Versions/A/CollectionViewCore
            Referenced from: <33D86ABE-3911-31E8-8574-72D3319C0EE4> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/serde_core-1.0.229/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)
          cc: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!
          cc: error: You can set the path to the Xcode folder using /usr/bin/xcode-select -switch
          

error: could not compile `serde_core` (build script) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
error: could not compile `proc-macro2` (build script) due to 1 previous error
error: linking with `cc` failed: exit status: 71
  |
  = note:  "cc" "/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/build/quote-410982f58b086895/rustcQGtg9v/symbols.o" "<2 object files omitted>" "<sysroot>/lib/rustlib/aarch64-apple-darwin/lib/{libstd-*,libpanic_unwind-*,libobject-*,libmemchr-*,libaddr2line-*,libgimli-*,libcfg_if-*,librustc_demangle-*,libstd_detect-*,libhashbrown-*,librustc_std_workspace_alloc-*,libminiz_oxide-*,libadler2-*,libunwind-*,liblibc-*,librustc_std_workspace_core-*,liballoc-*,libcore-*,libcompiler_builtins-*}.rlib" "-lSystem" "-lc" "-lm" "-arch" "arm64" "-mmacosx-version-min=11.0.0" "-o" "/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/build/quote-410982f58b086895/build_script_build-410982f58b086895" "-Wl,-dead_strip" "-nodefaultlibs"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: dyld[69549]: Library not loaded: /System/Library/PrivateFrameworks/AppleKeyStore.framework/Versions/A/AppleKeyStore
            Referenced from: <DE0D8141-40A2-3E24-A766-DAC36ABFC0B1> /System/Library/Frameworks/Security.framework/Versions/A/Security
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/CollectionsInternal.framework/Versions/A/CollectionsInternal
            Referenced from: <D25E0345-D6C1-3FAB-94EF-71753EC63659> /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/BiomeLibrary.framework/Versions/A/BiomeLibrary
            Referenced from: <EB538E77-842B-3181-A7E4-D6E4869016D9> /System/Library/PrivateFrameworks/DuetActivityScheduler.framework/Versions/A/DuetActivityScheduler
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/CollectionsInternal.framework/Versions/A/CollectionsInternal
            Referenced from: <6CD7E451-8913-338E-AA36-52C55D53883F> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)Library not loaded: /System/Library/PrivateFrameworks/CollectionViewCore.framework/Versions/A/CollectionViewCore
            Referenced from: <33D86ABE-3911-31E8-8574-72D3319C0EE4> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
            Reason: tried: '' (no such file), '/System/Volumes/Preboot/Cryptexes/OS' (not a file), '' (no such file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (no such file), '/Users/runner/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/quote-1.0.47/' (not a file), '/Users/runner/work/rust/rust/src/ci/citool/../../../build/citool/debug/deps/' (not a file), '/Users/runner/.rustup/toolchains/stable-aarch64-apple-darwin/lib/' (not a file), '/Users/runner/lib/' (no such file), '/usr/local/lib/' (no such file), '/usr/lib/' (not a file, not in dyld cache)
          cc: error: unable to locate xcodebuild, please make sure the path to the Xcode folder is set correctly!
          cc: error: You can set the path to the Xcode folder using /usr/bin/xcode-select -switch
          

error: could not compile `quote` (build script) due to 1 previous error
##[error]Process completed with exit code 101.
##[group]Run echo "disk usage:"

@clarfonthey

Copy link
Copy Markdown
Contributor

@bors retry

(spurious?)

@clarfonthey

Copy link
Copy Markdown
Contributor

Hooray, it finally merged! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.