Rollup of 4 pull requests by jhpratt · Pull Request #161999 · rust-lang/rust

jhpratt · 2026-08-30T04:09:03Z

Successful merges:

Refactored docs for std::fs::set_permissions_nofollow + fix BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW flag #160170 (Refactored docs for std::fs::set_permissions_nofollow + fix BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW flag)
Report the configured Polonius default in -Z help #161909 (Report the configured Polonius default in -Z help)
Add regression test for TAIT in extern fn ICE with the new solver #161969 (Add regression test for TAIT in extern fn ICE with the new solver)
add regression test for ICE unexpected region #161993 (add regression test for ICE unexpected region)

… on different platforms + fixed BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW

…tored non-BSD-based/non-Linux platforms to use OpenOptions open + set_permissions, and refactored tests accordingly

…ns ENOTSUP (e.g. for Ubuntu 20.04 returns ENOTSUP on non-symlinks + symlinks when using fchmodat with AT_SYMLINK_NOFOLLOW). Update docs accordingly as well and corrected behavior + docs for other Unix platforms with symlinks should return `FilesystemLoop` error instead of `InvalidInput` due to not setting `OpenOptions` with read enabled. Co-authored-by: Rachel Barker <rachel.barker@ferrous-systems.com>

…d fchmodat platform call on fchmodat and every platform falls back to open + fchmod when _res is set to ErrorKind::Unsupported; updated docs to reflect change

@clarfonthey

… r=clarfonthey Refactored docs for `std::fs::set_permissions_nofollow` + fix BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW flag Original Tracking Issue: rust-lang#141607 Fixes mistake made in rust-lang#158168 This PR refactors documentations for `std::fs::set_permissions_nofollow` and fixes BSD-based systems + Android to use `fchmodat` with `AT_SYMLINK_NOFOLLOW` flag (instead of no flag set) and refactors all other platforms to defer to `OpenOptions` with `O_NOFOLLOW` behavior. r? @clarfonthey Since they looked at the original `set_permissions_nofollow` PR I made cc @RalfJung

…ius-help-default, r=Kivooeo Report the configured Polonius default in -Z help Fixes rust-lang#161543

…nilla Add regression test for TAIT in extern fn ICE with the new solver Fixes rust-lang#156345

…=ShoyuVanilla add regression test for ICE unexpected region regression test for rust-lang#143896

jhpratt · 2026-08-30T04:09:13Z

@bors r+ p=5

rust-bors · 2026-08-30T04:09:16Z

📌 Commit 4096d8f has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-08-30T08:52:45Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 2m 16s
Pushing 3cabe36 to main...

github-actions · 2026-08-30T08:55:50Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing d0ea9cd (parent) -> 3cabe36 (this PR)

Test differences

Show 31 test diffs

Stage 1

[ui] tests/ui/associated-consts/assoc-const-equality-unexpected-region.rs: [missing] -> pass (J0)
[ui] tests/ui/lint/improper-ctypes/tait-extern-fn-next-solver-issue-156345.rs: [missing] -> pass (J0)
[ui (polonius)] tests/ui/associated-consts/assoc-const-equality-unexpected-region.rs: [missing] -> pass (J2)
[ui (polonius)] tests/ui/lint/improper-ctypes/tait-extern-fn-next-solver-issue-156345.rs: [missing] -> pass (J2)

Stage 2

[ui] tests/ui/associated-consts/assoc-const-equality-unexpected-region.rs: [missing] -> pass (J1)
[ui] tests/ui/lint/improper-ctypes/tait-extern-fn-next-solver-issue-156345.rs: [missing] -> pass (J1)
fs::tests::fchmodat_works: pass -> [missing] (J3)
fs::tests::set_get_permissions_nofollows: pass -> [missing] (J3)

Additionally, 23 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3cabe36ceb022e2f56d4d330b1e2886f31117f18 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu-gcc-core-tests: 10m 29s -> 17m 18s (+65.0%)
dist-arm-linux-musl: 1h 6m -> 1h 48m (+63.4%)
x86_64-gnu-stdlib-semver-check: 10m 26s -> 16m 53s (+61.8%)
x86_64-gnu-nopt: 1h 34m -> 2h 21m (+49.7%)
arm-android: 1h 21m -> 1h 54m (+39.7%)
dist-riscv64-linux-gnu: 1h 7m -> 1h 34m (+39.6%)
x86_64-msvc-ext3: 1h 22m -> 1h 54m (+38.4%)
dist-s390x-linux: 1h 8m -> 1h 34m (+38.3%)
i686-gnu-nopt-2: 1h 46m -> 2h 24m (+35.4%)
dist-x86_64-musl: 1h 43m -> 2h 20m (+35.4%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-08-30T09:36:50Z

Finished benchmarking commit (3cabe36): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.0%	[-3.0%, -3.0%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.0%	[-3.0%, -3.0%]	1

Cycles

Results (secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Bootstrap: 474.031s -> 475.389s (0.29%)
Artifact size: 402.86 MiB -> 402.85 MiB (-0.00%)

rust-bors · 2026-08-30T09:58:31Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#160170	Refactored docs for `std::fs::set_permissions_nofollow` + f…	`e4a4df2969faf25ed280b8b90035799933e4a713` (link)
#161909	Report the configured Polonius default in -Z help	`78775e68bca3801e7ad5d340576056dc1b5472f4` (link)
#161969	Add regression test for TAIT in extern fn ICE with the new …	`f05a4a1b9a29d24080a70d3f0bedfdeaa9824c6a` (link)
#161993	add regression test for ICE unexpected region	`70922315ecb850316c13a229f6221991e12fcddf` (link)

parent commit: d0ea9cd000

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

asder8215 and others added 12 commits August 21, 2026 14:29

Refactored std::fs::set_permissions_nofollow docs clarifying behavior…

babe876

… on different platforms + fixed BSD-based systems to use fchmodat with AT_SYMLINK_NOFOLLOW

Refactored documentation for std::fs::set_permissions_nofollow, refac…

dc3bf29

…tored non-BSD-based/non-Linux platforms to use OpenOptions open + set_permissions, and refactored tests accordingly

Add regression test for the Polonius help default

9c6ebca

Refactored set_perm_nofollow and have it written so that all supporte…

b901613

…d fchmodat platform call on fchmodat and every platform falls back to open + fchmod when _res is set to ErrorKind::Unsupported; updated docs to reflect change

Report the configured Polonius default in -Z help

3637675

Add regression test for TAIT in extern fn ICE with the new solver

d180f00

regression test for unexpected region ICE

1253a87

Rollup merge of rust-lang#161909 - chenyukang:yukang-fix-161543-polon…

473b04d

…ius-help-default, r=Kivooeo Report the configured Polonius default in -Z help Fixes rust-lang#161543

Rollup merge of rust-lang#161969 - zakrad:regr-test-156345, r=ShoyuVa…

5cac966

…nilla Add regression test for TAIT in extern fn ICE with the new solver Fixes rust-lang#156345

Rollup merge of rust-lang#161993 - malezjaa:unexpected-region-test, r…

4096d8f

…=ShoyuVanilla add regression test for ICE unexpected region regression test for rust-lang#143896

rust-bors Bot added the rollup A PR which is a rollup label Aug 30, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 30, 2026

rust-bors Bot merged commit 3cabe36 into rust-lang:main Aug 30, 2026
14 checks passed

rustbot added this to the 1.100.0 milestone Aug 30, 2026

This was referenced Aug 30, 2026

std: make a lot of items crate private #161612

Open

std: add platform support for hexagon-unknown-qurt #152084

Open

Navigation Menu

Uh oh!

Uh oh!

Rollup of 4 pull requests - #161999

Rollup of 4 pull requests#161999
rust-bors[bot] merged 12 commits into
rust-lang:mainfrom
jhpratt:rollup-8H6NhYe

jhpratt commented Aug 30, 2026

Uh oh!

jhpratt commented Aug 30, 2026

Uh oh!

rust-bors Bot commented Aug 30, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 30, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 30, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Aug 30, 2026

Uh oh!

rust-bors Bot commented Aug 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

jhpratt commented Aug 30, 2026

Uh oh!

jhpratt commented Aug 30, 2026

Uh oh!

rust-bors Bot commented Aug 30, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 30, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 30, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 30, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-bors Bot commented Aug 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants