Skip to content

Fix Danger changelog check for bot PRs and add Swagger UI release notes - #182

Merged
moskvin merged 2 commits into
ruby-grape:masterfrom
moskvin:fix-bot-changelog-and-swagger-ui-notes
Oct 13, 2026
Merged

moskvin merged 2 commits into
ruby-grape:masterfrom
moskvin:fix-bot-changelog-and-swagger-ui-notes

Conversation

@moskvin

@moskvin moskvin commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Scheduled Swagger UI update PRs (e.g. #181) fail Danger because the changelog entry is attributed to [@github-actions[bot]](...), and danger-changelog only accepts [\w-]+ author names.

  • script/update_changelog: strip the [bot] suffix from the author, and rewrite an existing entry for the PR only when Danger would reject it (hand-edited valid entries are left alone).
  • script/swagger_ui_release_notes: new script that builds the PR body from upstream swagger-api/swagger-ui release notes for every release between the bundled and the new version (with a compare link, normalized headings, and @mentions escaped so upstream contributors aren't pinged).
  • .github/workflows/swagger-ui-update.yml: use that script for the PR body.

🤖 Generated with Claude Code

moskvin and others added 2 commits October 13, 2026 12:15
danger-changelog rejects `[@github-actions[bot]]` author links, so strip the
`[bot]` suffix and repair existing entries that Danger would reject. The
scheduled Swagger UI update PR now lists upstream release notes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Danger Report

No issues found.

View run

@moskvin
moskvin merged commit 73c4d0d into ruby-grape:master Oct 13, 2026
10 checks passed
@dblock

dblock commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

PR a fix to danger-changelog? Update: opened dblock/danger-changelog#72 to accept [bot] author attribution without stripping the suffix, including GitHub app and bot profile links. Once released and upgraded here, we can remove the suffix-stripping workaround.

Edit by Copilot (AI), on behalf of @dblock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants