Skip to content

Accept GitHub bot logins in changelog author links - #72

Merged
dblock merged 1 commit into
masterfrom
dblock/bot-authors
Oct 14, 2026
Merged

dblock merged 1 commit into
masterfrom
dblock/bot-authors

Conversation

@dblock

@dblock dblock commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Summary

Accept author labels ending in the literal [bot] suffix without stripping or rewriting attribution. This fixes the limitation behind the workaround in ruby-grape/grape-swagger-rails#182 and ensures that examples generated from bot PR metadata pass our own validator.

  • Share author-name and strict author-link patterns across entry validation, detection, and description-punctuation checks.
  • Support GitHub app links and bot profile URLs, including the existing example generator’s URL format.
  • Preserve existing HTTPS, punctuation, spacing, and ordinary-user behavior; reject malformed bot suffixes.
  • Add generated-example, line-validation, diagnostic, and complete-changelog regression coverage, plus a documented bot attribution example.

No bot-specific configuration or attribution normalization is required. Consumers can remove suffix-stripping workarounds after upgrading.

Validation

bundle exec rake spec: 192 examples pass, RuboCop passes, and Danger plugin documentation lint passes. Refreshed the ignored local lockfile for compatibility with Ruby 3.3; no dependency manifest or lockfile changes are included.

@dblock
dblock force-pushed the dblock/bot-authors branch from d488b3c to ef4e723 Compare October 14, 2026 15:41
@github-actions

Copy link
Copy Markdown

Danger Report

✅ All checks passed!

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dblock
dblock force-pushed the dblock/bot-authors branch from 28606a3 to 61b31aa Compare October 14, 2026 15:45
@dblock
dblock merged commit 06c948d into master Oct 14, 2026
13 checks passed
@dblock
dblock deleted the dblock/bot-authors branch October 14, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant