Add SimpleCov and Coveralls integration, bring coverage to 100%

.github/workflows/test.yml

@@ -26,3 +26,19 @@ jobs:
         with:
           run: |
             bundle exec rake spec
+      - name: Coveralls
+        uses: coverallsapp/github-action@v2
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          flag-name: run-${{ matrix.ruby }}
+          parallel: true
+
+  finish:
+    needs: test
+    runs-on: ubuntu-latest
+    steps:
+      - name: Coveralls Finished
+        uses: coverallsapp/github-action@v2
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          parallel-finished: true

.gitignore

@@ -4,4 +4,5 @@
 .irbrc
 .bundle
 log
-vendor
+vendor
+coverage

.simplecov

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+if ENV['CI'] # only when running CI
+  require 'simplecov-lcov'
+  SimpleCov::Formatter::LcovFormatter.config do |c|
+    c.report_with_single_file = true
+    c.single_report_path = 'coverage/lcov.info'
+  end
+
+  SimpleCov.formatter = SimpleCov::Formatter::LcovFormatter
+end
+
+SimpleCov.start do
+  enable_coverage :branch
+  add_filter '/spec/'
+end

Gemfile

@@ -31,4 +31,6 @@ group :test do
   gem 'rack-test'
   gem 'rspec'
   gem 'selenium-webdriver'
+  gem 'simplecov', require: false
+  gem 'simplecov-lcov', require: false
 end

Gemfile.lock

@@ -202,6 +202,8 @@ GEM
       rubyzip (>= 1.2.2, < 4.0)
       websocket (~> 1.0)
     shellany (0.0.1)
+    simplecov (1.1.1)
+    simplecov-lcov (0.9.0)
     spoon (0.0.6)
       ffi
     thor (1.5.0)
@@ -246,6 +248,8 @@ DEPENDENCIES
   rubocop-rake
   rubocop-rspec
   selenium-webdriver
+  simplecov
+  simplecov-lcov
 
 BUNDLED WITH
   4.0.16

README.md

@@ -2,6 +2,7 @@ Grape API on Rack
 =================
 
 [![Test](https://github.com/ruby-grape/grape-on-rack/actions/workflows/test.yml/badge.svg?branch=master)](https://github.com/ruby-grape/grape-on-rack/actions/workflows/test.yml)
+[![Coverage Status](https://coveralls.io/repos/github/ruby-grape/grape-on-rack/badge.svg?branch=master)](https://coveralls.io/github/ruby-grape/grape-on-rack?branch=master)
 
 A [Grape](http://github.com/ruby-grape/grape) API mounted on Rack.
 

app/acme_app.rb

@@ -3,7 +3,11 @@ class App
     def initialize
       @filenames = ['', '.html', 'index.html', '/index.html']
       @rack_static = ::Rack::Static.new(
+        # Rack::Static requires a fallback app, but since urls: ['/'] matches every
+        # request, it never falls back to this and the lambda is never called.
+        # simplecov:disable
         -> { [404, {}, []] },
+        # simplecov:enable
         root: File.expand_path('../public', __dir__),
         urls: ['/']
       )

spec/api/get_json_spec.rb

@@ -18,4 +18,11 @@ def app
       { id: 2, reticulated: false }
     ].to_json)
   end
+
+  it 'leaves a non-JSON param unchanged' do
+    get '/api/reticulated_splines', 'splines' => [
+      { id: 1, reticulated: false }
+    ].to_json, 'not_json' => 'not valid json'
+    expect(last_response.status).to eq(200)
+  end
 end

spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'rubygems'
+require 'simplecov'
 
 ENV['RACK_ENV'] ||= 'test'