Repository navigation
Add SimpleCov and Coveralls integration, bring coverage to 100% - #95
Merged
Merged
Conversation
Adds a test for the non-JSON param rescue branch in Acme::GetJson, and documents (with an explanatory comment marked for SimpleCov exclusion) the unreachable fallback lambda passed to Rack::Static in Acme::App, since urls: ['/'] matches every request and never falls back to it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
add-simplecov-coveralls
branch
from
September 3, 2026 23:17
ecc1301 to
fb1981c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds SimpleCov coverage tracking with the Coveralls GitHub Action, following the same convention used in ruby-grape/grape.
simplecovandsimplecov-lcovto the test group..simplecovconfig (line + branch coverage, lcov output for Coveralls in CI).simplecovfirst inspec/spec_helper.rb.coverageto.gitignore..github/workflows/test.ymlto report to Coveralls per matrix entry (parallel) with afinishjob.Coverage is now 100% (line and branch):
spec/api/get_json_spec.rbfor the non-JSON param rescue branch inAcme::GetJson.Rack::Static.newinAcme::Appwith an explanatory comment (urls: ['/']matches every request, so the fallback app is never actually invoked), marked withsimplecov:disable/simplecov:enablerather than writing a synthetic test for genuinely dead code.Testing
bundle exec rspec- 43 examples, 0 failures, 100% line/branch coverage.bundle exec rubocop- clean, no offenses.