Skip to content

Fix build warnings #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
130s merged 3 commits into from
Sep 30, 2026
Merged

Fix build warnings #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fc3fb1
Fix build warnings
johanneskbl Apr 23, 2026
0304341
Fix build warnings smach_ros
johanneskbl Apr 23, 2026
e39034f
Update smach_ros/setup.py
130s Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions smach/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[develop]
script-dir=$base/lib/smach
script_dir=$base/lib/smach
[install]
install-scripts=$base/lib/smach
install_scripts=$base/lib/smach
7 changes: 1 addition & 6 deletions smach/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,7 @@
zip_safe=True,
maintainer='Isaac I. Y. Saito',
maintainer_email='gm130s@gmail.com',
description='''
SMACH is a task-level architecture for rapidly creating complex robot
behavior. At its core, SMACH is a ROS-independent Python library to build
hierarchical state machines. SMACH is a new library that takes advantage of
very old concepts in order to quickly create robust robot behavior with
maintainable and modular code.''',
description='SMACH is a task-level architecture for rapidly creating complex robot behavior. At its core, SMACH is a ROS-independent Python library to build hierarchical state machines. SMACH is a new library that takes advantage of very old concepts in order to quickly create robust robot behavior with maintainable and modular code.',

@130s 130s Sep 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking; The change in this file seems unrelated to the PR objective. Normally we should not merge things like this but this particular change doesn't really matter.

license='BSD',
data_files=[
('share/ament_index/resource_index/packages',
Expand Down
4 changes: 2 additions & 2 deletions smach_ros/setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[develop]
script-dir=$base/lib/smach_ros
script_dir=$base/lib/smach_ros
[install]
install-scripts=$base/lib/smach_ros
install_scripts=$base/lib/smach_ros
7 changes: 1 addition & 6 deletions smach_ros/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,7 @@
zip_safe=True,
maintainer='Isaac I. Y. Saito',
maintainer_email='gm130s@gmail.com',
description='''
SMACH is a task-level architecture for rapidly creating complex robot
behavior. At its core, SMACH is a ROS-independent Python library to build
hierarchical state machines. SMACH is a new library that takes advantage of
very old concepts in order to quickly create robust robot behavior with
maintainable and modular code.''',
description='SMACH is a task-level architecture for rapidly creating complex robot behavior. SMACH is a new library that takes advantage of very old concepts in order to quickly create robust robot behavior with maintainable and modular code.',
license='BSD',
data_files=[
('share/ament_index/resource_index/packages',
Expand Down