Skip to content

Fix build warnings - #132

Merged
130s merged 3 commits into
ros:ros2from
johanneskbl:PR/fix-build-warnings
Sep 30, 2026
Merged

Fix build warnings#132
130s merged 3 commits into
ros:ros2from
johanneskbl:PR/fix-build-warnings

Conversation

@johanneskbl

@johanneskbl johanneskbl commented Apr 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

When building my project that depends on this repo I receive the following warnings that stem from wrong interface to setuptools/dist.py:

Starting >>> smach
/usr/lib/python3/dist-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
  warnings.warn(
/usr/lib/python3/dist-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'install-scripts' will not be supported in future versions. Please use the underscore name 'install_scripts' instead
  warnings.warn(
--- stderr: smach                     
/usr/lib/python3/dist-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
  warnings.warn(
/usr/lib/python3/dist-packages/setuptools/dist.py:157: UserWarning: newlines not allowed and will break in the future
  warnings.warn("newlines not allowed and will break in the future")
---
Finished <<< smach

as well as

Starting >>> smach_ros
/usr/lib/python3/dist-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
  warnings.warn(
/usr/lib/python3/dist-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'install-scripts' will not be supported in future versions. Please use the underscore name 'install_scripts' instead
  warnings.warn(
--- stderr: smach_ros                 
/usr/lib/python3/dist-packages/setuptools/dist.py:723: UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead
  warnings.warn(
/usr/lib/python3/dist-packages/setuptools/dist.py:157: UserWarning: newlines not allowed and will break in the future
  warnings.warn("newlines not allowed and will break in the future")
---
Finished <<< smach_ros [0.52s]

My setup is Ubuntu 22.04 and ROS2 Humble and the standard
python3-setuptools/jammy-updates,jammy-updates,jammy-security,jammy-security,now 59.6.0-1.2ubuntu0.22.04.3 all
python3-colcon-core/jammy,jammy,now 0.20.1+upstream-1
python3-colcon-ros-distro/jammy,jammy 0.1.0-100

It is not breaking anything but would be neat to clean this up such that warnings are reduced.

@henxing

henxing commented Sep 30, 2026

Copy link
Copy Markdown

Worth a try since this seems unmaintained...

130s
130s approved these changes Sep 30, 2026
View reviewed changes

@130s 130s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution!

Comment thread smach/setup.py
hierarchical state machines. SMACH is a new library that takes advantage of
very old concepts in order to quickly create robust robot behavior with
maintainable and modular code.''',
description='SMACH is a task-level architecture for rapidly creating complex robot behavior. At its core, SMACH is a ROS-independent Python library to build hierarchical state machines. SMACH is a new library that takes advantage of very old concepts in order to quickly create robust robot behavior with maintainable and modular code.',

@130s 130s Sep 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking; The change in this file seems unrelated to the PR objective. Normally we should not merge things like this but this particular change doesn't really matter.

Comment thread smach_ros/setup.py Outdated
@130s
130s merged commit 88f808e into ros:ros2 Sep 30, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@130s 130s 130s approved these changes
+1 more reviewer
@henxing henxing henxing approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johanneskbl @henxing @130s