Repository navigation
fix(grillme): require a recommended answer on inline questions - #9
Conversation
The original grilling skill always paired each question with a recommended answer. The inline-thread rewrite dropped that, so turn-1 comments on #7 were probes with no stance. Restore **Recommended:** on new inline comments and on follow-up replies that still ask a decision question. Omit it only when the agent truly has no technical default. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Finished Review · ✅ Success · Started 7:22 PM UTC · Completed 7:35 PM UTC Commit: |
ReviewFindingsLow
|
There was a problem hiding this comment.
Note: The following inline comments could not be posted on the diff (GitHub returned 422) and are included here instead:
.fullsend/custom/skills/grilling/SKILL.md(file-level): Line 30 · [low] internal consistency
SKILL.md step 2 ('Reply in-thread when an answer needs a follow-up') is not updated to mention including Recommended: on follow-up replies, while grillme.md explicitly adds this rule at lines 225-226. The two documents now diverge on follow-up behavior. In practice the agent definition (grillme.md) is the primary runtime document and does contain the instruction, so the risk is low.
Suggested fix: Add a clause to SKILL.md step 2 such as: 'When a follow-up is itself a decision question, include Recommended: the same way as new comments.'
|
🤖 Finished Retro · ✅ Success · Started 7:41 PM UTC · Completed 7:48 PM UTC Commit: |
Retro: PR #9 — fix(grillme): require a recommended answer on inline questionsWhat happenedPR #9 was a human-authored fix (johnmcollier, with Cursor) to the grillme agent configuration. It restored the The review agent (run 32518019927, fullsend v0.36.0, agents from Workflow quality
Observations on existing tracked issues
What went wellThe overall workflow was healthy: real-world testing (grillme on PR #7) surfaced a UX gap, a human authored a targeted fix, and the review agent provided useful feedback. The review agent correctly identified the one remaining consistency issue in a 2-file, 24-line change to agent configuration files — solid performance on a meta-review task (reviewing agent definitions). Proposals filed
|
Summary
Grillme's inline threads on #7 asked good questions but never took a stance. The original one-question model always included Recommended answer; that was lost in the thread rewrite.
This restores it:
question+**Recommended:** <answer and why>Prompt + grilling skill both updated. Example comment bodies in the agent output contract now include the recommendation line.
After merge, a new
/fs-grillmesession on a PR will pick this up (workflow readsmain). Existing threads on #7 will not be rewritten; start a fresh session or continue and look for recommendations on new/follow-up comments.Test plan
/fs-grillmeon docs: OpenSpec for task status workflow #7 (or a new OpenSpec PR)Made with Cursor