Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions subgraph/networks.json
Original file line number Diff line number Diff line change
@@ -1,26 +1,8 @@
{
"arbitrum-one": {
"Raindex": {
"address": "0x37FC0EFec37D19f8A221aa4F8F7600C9ba2AcD20",
"startBlock": 473899359
}
},
"matic": {
"Raindex": {
"address": "0x37FC0EFec37D19f8A221aa4F8F7600C9ba2AcD20",
"startBlock": 88573024
}
},
"base": {
"Raindex": {
"address": "0x37FC0EFec37D19f8A221aa4F8F7600C9ba2AcD20",
"startBlock": 47387582
}
},
"flare": {
"Raindex": {
"address": "0x37FC0EFec37D19f8A221aa4F8F7600C9ba2AcD20",
"startBlock": 63011168
"address": "0xe522cB4a5fCb2eb31a52Ff41a4653d85A4fd7C9D",
"startBlock": 41747644

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Use the canonical Base deployment block.

This value is 41747644, but src/lib/deploy/LibRaindexDeploy.sol defines RAINDEX_START_BLOCK_BASE as 47387582, and test/lib/deploy/LibRaindexDeployNetworksJsonStartBlockBase.t.sol asserts those values are equal. The current change will fail that test and may trigger unnecessary historical indexing.

Proposed fix
-      "startBlock": 41747644
+      "startBlock": 47387582
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"startBlock": 41747644
"startBlock": 47387582
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@subgraph/networks.json` at line 17, Update the Base network’s startBlock in
subgraph/networks.json to match the canonical RAINDEX_START_BLOCK_BASE value
defined by LibRaindexDeploy and asserted by
LibRaindexDeployNetworksJsonStartBlockBase.t.sol, using 47387582.

}
}
}
Loading