Update networks.json#2813
Conversation
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe base network’s Raindex configuration now uses a new address and starting block. Other network entries remain unchanged. ChangesBase Raindex configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@subgraph/networks.json`:
- Line 17: Update the Base network’s startBlock in subgraph/networks.json to
match the canonical RAINDEX_START_BLOCK_BASE value defined by LibRaindexDeploy
and asserted by LibRaindexDeployNetworksJsonStartBlockBase.t.sol, using
47387582.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 575758c2-713f-4634-b457-ca0a3e4384be
📒 Files selected for processing (1)
subgraph/networks.json
| "address": "0x37FC0EFec37D19f8A221aa4F8F7600C9ba2AcD20", | ||
| "startBlock": 47387582 | ||
| "address": "0xe522cB4a5fCb2eb31a52Ff41a4653d85A4fd7C9D", | ||
| "startBlock": 41747644 |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Use the canonical Base deployment block.
This value is 41747644, but src/lib/deploy/LibRaindexDeploy.sol defines RAINDEX_START_BLOCK_BASE as 47387582, and test/lib/deploy/LibRaindexDeployNetworksJsonStartBlockBase.t.sol asserts those values are equal. The current change will fail that test and may trigger unnecessary historical indexing.
Proposed fix
- "startBlock": 41747644
+ "startBlock": 47387582📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "startBlock": 41747644 | |
| "startBlock": 47387582 |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@subgraph/networks.json` at line 17, Update the Base network’s startBlock in
subgraph/networks.json to match the canonical RAINDEX_START_BLOCK_BASE value
defined by LibRaindexDeploy and asserted by
LibRaindexDeployNetworksJsonStartBlockBase.t.sol, using 47387582.
Motivation
Solution
Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit