Skip to content

docs: clarify sflr-exchange-rate meta direction and add input arity#136

Merged
thedavidmeister merged 5 commits into
mainfrom
fix/issue-95-104-sflr-meta-description
Jul 9, 2026
Merged

docs: clarify sflr-exchange-rate meta direction and add input arity#136
thedavidmeister merged 5 commits into
mainfrom
fix/issue-95-104-sflr-meta-description

Conversation

@thedavidmeister

Copy link
Copy Markdown
Collaborator

Summary

The sflr-exchange-rate authoring meta description had two gaps:

#104 (direction ambiguity): "Returns the current exchange rate of FLR to SFLR." doesn't state which token is the numerator. The runtime returns getSharesByPooledFlr(1e18) — sFLR-per-FLR. An author reading it as FLR-per-sFLR would invert their math.

#95 (input count): ftso-current-price-usd says "Accepts 2 inputs" and ftso-current-price-pair says "Accepts 3 inputs". sflr-exchange-rate said nothing, leaving tooling consumers without a consistent in-meta arity signal.

New description: "Returns the current sFLR per FLR exchange rate self-reported by the Sceptre staked FLR contract, i.e. how many sFLR shares correspond to 1 FLR. A value less than 1 means 1 FLR yields fewer than 1 sFLR share. Accepts 0 inputs."

SUB_PARSER_PARSE_META is unaffected — it is built from word names only (bloom filter / fingerprint), not descriptions.

Note: PR #130 adds testAuthoringMetaV2Content which pins the old description. Once this PR merges, that test's sflr-exchange-rate assertion must be updated to the new string before PR #130 can merge.

Closes #95
Closes #104

Co-Authored-By: Claude noreply@anthropic.com

Closes #95
Closes #104

Co-Authored-By: Claude <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Jun 16, 2026
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thedavidmeister, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 31 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6d2b5e08-d292-4d95-857f-ce868aaa63cb

📥 Commits

Reviewing files that changed from the base of the PR and between cb20d03 and 107a0b3.

⛔ Files ignored due to path filters (1)
  • src/generated/FlareFtsoWords.pointers.sol is excluded by !**/generated/**
📒 Files selected for processing (3)
  • meta/FlareFtsoSubParserAuthoringMeta.rain.meta
  • meta/FlareFtsoWords.rain.meta
  • src/lib/parse/LibFlareFtsoSubParser.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-95-104-sflr-meta-description

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

thedavidmeister and others added 4 commits June 16, 2026 22:22
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The meta string is compiled into FlareFtsoWords, so the earlier
DESCRIBED_BY_META_HASH/meta CBOR regen also changed the bytecode.
Regenerate src/generated/FlareFtsoWords.pointers.sol so BYTECODE_HASH
matches, unblocking copy-artifacts.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister thedavidmeister added the ai:ready AI vetter: passes review, ready for human decision label Jul 6, 2026
@thedavidmeister

thedavidmeister commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 ai:vetter
Reviewed 107a0b3: ready — Meta description corrected to sFLR-per-FLR with explicit input arity; binary artifacts and hashes re
cost 142 — doc string change plus codegen-checked regenerated artifacts

@thedavidmeister
thedavidmeister merged commit 3329650 into main Jul 9, 2026
5 checks passed
thedavidmeister added a commit that referenced this pull request Jul 10, 2026
…work)

Merges main (the #136 description rewrite landed after this branch) and
pins authoringMeta[2].description to the source string in
LibFlareFtsoSubParser.sol.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai:ready AI vetter: passes review, ready for human decision

Projects

None yet

1 participant