test: assert authoringMetaV2 word names and descriptions

[thedavidmeister]

Summary

testSubParserParseMeta verified that authoringMetaV2() produces bytes that hash correctly into the parse meta, but never asserted the actual word names or description strings. Any mutation to a word name or description text would silently pass.

Adds testAuthoringMetaV2Content which decodes the authoring meta and pins:

• Array length == 3
• Each word field (ftso-current-price-usd, ftso-current-price-pair, sflr-exchange-rate)
• Full description string for each word

Mutation-validated: flipping "ftso-current-price-usd" → "ftso-current-price-us" in the source produces a bytes32 assertion failure.

Closes #84

Co-Authored-By: Claude noreply@anthropic.com

Summary by CodeRabbit

• Tests
  • Added coverage to verify the decoded authoring metadata output, including the number of entries, expected words, and their descriptions.

[coderabbitai]

Warning

Review limit reached

@thedavidmeister, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 969ee3e6-8946-4043-8189-da2ceb7a3cea

📥 Commits

Reviewing files that changed from the base of the PR and between 3a21eed and fc9ef5b.

📒 Files selected for processing (1)

• test/src/concrete/FlareFtsoWords.pointers.t.sol

Walkthrough

A new external pure test function, testAuthoringMetaV2Content(), was added to verify the decoded content of authoringMetaV2() from LibFlareFtsoSubParser, asserting array length, word values, and description strings for three entries.

Changes

Authoring metadata content test

Layer / File(s)	Summary
Add authoringMetaV2 content assertions test/src/concrete/FlareFtsoWords.pointers.t.sol	New test decodes authoringMetaV2() into an AuthoringMetaV2[] array and asserts its length is 3, plus the word and description values for each of the three entries.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• rainlanguage/rain.flare#173: Both PRs add tests to test/src/concrete/FlareFtsoWords.pointers.t.sol that decode and assert authoringMetaV2() word and description content.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding assertions for authoringMetaV2 word names and descriptions.
Linked Issues check	✅ Passed	The new test directly decodes authoringMetaV2 and asserts the expected length, index-to-name mapping, and descriptions as requested in #84.
Out of Scope Changes check	✅ Passed	The PR only adds the targeted content test in the specified file and does not introduce unrelated changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/issue-84-authoring-meta-assertion

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[thedavidmeister]

Producer note: backing off per protocol — this branch already carries a merge(main): resolve conflicts [merge-update] commit but main has moved again and the PR is CONFLICTING once more. Single conflicting file: test/src/concrete/FlareFtsoWords.pointers.t.sol. This PR adds testAuthoringMetaV2Content (pins exact word names + full description strings); main has since landed testAuthoringMetaContent (same words, but only asserts descriptions are non-empty) plus testOpcodePointersLength / testBytecodeHashMatchesDeployedCode at the same insertion point. A mechanical union (keep both, no name clash) is possible, but main's test partially supersedes this PR's — needs a human call: keep both tests, or rework to strengthen main's testAuthoringMetaContent in place with the full-description pins.

[thedavidmeister]

🤖 ai:producer
Producer note: state change — sibling PR #173 (pointer/authoring tests for #81/#84) has MERGED into main, but issue #84 is still OPEN. Producer rework queued: diff this branch's authoringMetaV2 word-name/description assertions against what #173 landed, keep only the remainder #84 still needs (or flag close-candidate if #173 fully covers it), against current main.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@test/src/concrete/FlareFtsoWords.pointers.t.sol`:
- Around line 54-71: The tests `testAuthoringMetaV2Content` and
`testAuthoringMetaContent` overlap by decoding
`LibFlareFtsoSubParser.authoringMetaV2()` and asserting the same `word`/length
coverage for the same three entries. Consolidate this into a single test by
removing `testAuthoringMetaV2Content` and strengthening
`testAuthoringMetaContent` to assert the full description strings for each
`AuthoringMetaV2` entry, keeping the existing unique `word` checks in that one
test.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 40d77796-75b3-4aac-83db-d097b47d396c

📥 Commits

Reviewing files that changed from the base of the PR and between a91ffe1 and 3a21eed.

📒 Files selected for processing (1)

• test/src/concrete/FlareFtsoWords.pointers.t.sol

[thedavidmeister]

🤖 ai:vetter
Reviewed 3a21eed: reject — missing/false QA evidence: body lacks QA-GUIDE section-8 block. inline mutation claim exists but no
cost 138 — test-only authoring-meta content pin

[thedavidmeister]

Rework note (human): now stale after #136 merged. Line 24 asserts the OLD sflr-exchange-rate description "Returns the current exchange rate of FLR to SFLR.", which #136 replaced with "Returns the current sFLR per FLR exchange rate self-reported by the Sceptre staked FLR contract, i.e. how many sFLR shares correspond to 1 FLR. A value less than 1 means 1 FLR yields fewer than 1 sFLR share. Accepts 0 inputs.". Rebase on main and update that assertion to the new string (the rest of the name/description pins look fine). Otherwise the test fails against current main.