Skip to content

Deploy DiaWords deterministically via Zoltu#39

Open
Siddharth2207 wants to merge 2 commits into
audit/parse-eval-encoding-contractfrom
audit/deterministic-deployment
Open

Deploy DiaWords deterministically via Zoltu#39
Siddharth2207 wants to merge 2 commits into
audit/parse-eval-encoding-contractfrom
audit/deterministic-deployment

Conversation

@Siddharth2207

@Siddharth2207 Siddharth2207 commented Jul 16, 2026

Copy link
Copy Markdown

Summary

  • replace nonce-dependent new DiaWords() in script/Deploy.sol with Zoltu CREATE2 deployment
  • add LibDiaWordsDeploy pinning expected address and runtime codehash
  • test address derivation, codehash self-consistency, and Zoltu deploy replay

Test plan

  • nix develop -c forge test (16 passed, 0 failed)
  • CI copy-artifacts + rainix-sol

Addresses audit HIGH finding: non-deterministic production deploy path.

Made with Cursor

@coderabbitai

coderabbitai Bot commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 00322805-d6ee-4bb5-abe1-52c243162efb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch audit/deterministic-deployment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This was referenced Jul 16, 2026
Open
Open
Open
Siddharth2207 and others added 2 commits July 16, 2026 19:28
@Siddharth2207 @cursoragent
Deploy DiaWords deterministically via Zoltu CREATE2
007ec8a 
Replace nonce-dependent `new DiaWords()` in the deploy script with a pinned
Zoltu deployment record and tests that lock address and codehash invariants.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207 @cursoragent
Fix CI: slither too-many-digits and forge fmt on Deploy.sol
85ec05c 
Keep type(DiaWords).creationCode in script/tests only so slither does not
analyze the embedded bytecode literal in src/lib/deploy.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207
Siddharth2207 force-pushed the audit/deterministic-deployment branch from 156deac to 85ec05c Compare July 16, 2026 13:59
@Siddharth2207
Siddharth2207 changed the base branch from 2026-05-16-update-dia-oracle to audit/parse-eval-encoding-contract July 16, 2026 13:59
This was referenced Jul 16, 2026
Open
Open
Open
Open
@Siddharth2207 Graphite App

Siddharth2207 commented Jul 16, 2026

Copy link
Copy Markdown
Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jul 16, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Siddharth2207