Skip to content

Preserve untagged FrozenCircuit instance across with_tags calls #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mshearn wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −0
Open

Preserve untagged FrozenCircuit instance across with_tags calls #8422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19201f8
Preserve untagged FrozenCircuit instance across with_tags calls
mshearn Oct 9, 2026
f91333a
Add identity assertions for FrozenCircuit.with_tags(...).untagged
mshearn Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cirq-core/cirq/circuits/frozen_circuit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def with_tags(self, *new_tags: Hashable) -> cirq.FrozenCircuit:
return self
new_circuit = FrozenCircuit(tags=self.tags + new_tags)
new_circuit._moments = self._moments
new_circuit.untagged = self.untagged
return new_circuit

@_compat.cached_method
Expand Down
3 changes: 3 additions & 0 deletions cirq-core/cirq/circuits/frozen_circuit_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,9 @@ def test_tagged_circuits() -> None:
assert tagged_circuit.with_tags("c") == cirq.FrozenCircuit(ops, tags=[*tags, "c"])
assert tagged_circuit.untagged == frozen_circuit
assert frozen_circuit.untagged is frozen_circuit
assert frozen_circuit.with_tags(*tags).untagged is frozen_circuit
assert frozen_circuit.with_tags("a").untagged is frozen_circuit.with_tags("b").untagged
assert frozen_circuit.with_tags("a").with_tags("b").untagged is frozen_circuit
assert tagged_circuit.unfreeze(copy=True).tags == tags
assert tagged_circuit.unfreeze(copy=False).tags == tags
# Test parameterized protocols
Expand Down
Loading