Repository navigation
Conversation
In FrozenCircuit.with_tags, forward `new_circuit.untagged = self.untagged` alongside `new_circuit._moments = self._moments` so that calling `.untagged` on any tagged wrapper returns the original untagged FrozenCircuit instance (`c.with_tags('a').untagged is c` and `c.with_tags('a').untagged is c.with_tags('b').untagged`) without allocating a duplicate FrozenCircuit.
Verify in test_tagged_circuits that calling .untagged on tagged FrozenCircuit copies returns the exact same untagged FrozenCircuit instance (`is`).
Author
|
@maffoo for review when you have a chance — thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8422 +/- ##
==========================================
- Coverage 99.59% 99.59% -0.01%
==========================================
Files 1133 1133
Lines 103919 103923 +4
==========================================
- Hits 103498 103497 -1
- Misses 421 426 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
FrozenCircuit.with_tags, forwardnew_circuit.untagged = self.untaggedalongsidenew_circuit._moments = self._momentsso that calling.untaggedon any tagged wrapper returns the original untaggedFrozenCircuitinstance (c.with_tags('a').untagged is candc.with_tags('a').untagged is c.with_tags('b').untagged) without allocating a duplicateFrozenCircuit.