Skip to content

Per-window review panels for pop-out windows - #43

Closed
jas-ho wants to merge 0 commit into
philphilphil:mainfrom
jas-ho:feat/per-window-review-panel
Closed

jas-ho wants to merge 0 commit into
philphilphil:mainfrom
jas-ho:feat/per-window-review-panel

Conversation

@jas-ho

@jas-ho jas-ho commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Pop-out windows have no sidebars, so the single panel in the main window's right sidebar is unreachable from them.

This scopes panel lookup and creation to the window of the originating leaf (split beside the note in a pop-out, right sidebar in the main window). Panels follow only their own window's active file; edits from any panel refresh all panels.

Tests: new test/per-window-panel.test.mjs, all suites pass; typecheck and lint clean (one activeLeaf deprecation warning, needed to capture the originating leaf for non-markdown views).

🤖 Generated with Claude Code

https://claude.ai/code/session_01B3gjHA78v78CmZRnGTLJmM

philphilphil pushed a commit that referenced this pull request Oct 15, 2026
Pop-out windows have no sidebars, so the single panel in the main window's
right sidebar was unreachable from them. Panel lookup and creation are now
scoped to the originating leaf's window (split beside the note in a pop-out,
panelLocation in the main window). Panels follow only their own window's
active file; edits from any panel refresh all panels.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@philphilphil
philphilphil force-pushed the feat/per-window-review-panel branch from 71ee185 to bd7d5f8 Compare October 15, 2026 19:43
@philphilphil

Copy link
Copy Markdown
Owner

closed wronly, it was merged, thx:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants