feat: upgrade to frontend-base 2.0, add the Catalog app - #328
Conversation
| @@ -0,0 +1,3 @@ | |||
| - 💥[Feature] Ship the Catalog as a frontend app (`@openedx/frontend-app-catalog`), enabled by default. The legacy Catalog MFE is no longer served: it stays declared in `MFE_APPS`, pinned to its `legacy-mfe` branch, for operators who disable the `catalog` frontend app. (by @arbrandes) | |||
| - [Improvement] Populate `FRONTEND_SITE_CONFIG["apps"]`, so that per-app runtime configuration can be set from the `mfe-lms-*-settings` patches. Unlike `commonAppConfig`, these values override the defaults an app ships. (by @arbrandes) | |||
| - [Bugfix] Set `ENABLE_CATALOG_MICROFRONTEND` in the CMS as well, so that Studio's course "about" links point at the catalog instead of the LMS. (by @arbrandes) | |||
There was a problem hiding this comment.
Good catch!
This also got me looking into openedx-platform itself. It looks like we're past the toggle_target_removal_date for ENABLE_CATALOG_MICROFRONTEND. I'm not sure about the timing of removing the toggle and actually removing the legacy frontend code though, so I let a comment on the DEPR issue suggesting flipping that to default True openedx/openedx-platform#36785 (comment)
That being said, if we expect the actual legacy frontend removal to happen quickly then setting this here means not needing to add something to cms/envs in openedx-platform for an extremely limited time.
98ec6fb to
fd4eec4
Compare
173ece7 to
4ba047c
Compare
149cf81 to
c44a66c
Compare
f4e24ac to
46c0fba
Compare
Include the new Catalog app, and in doing so, move the whole site to frontend-base 2.0. Authn and Learner Dashboard join the others in being enabled by default. Closes overhangio#330. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
edx-platform migrated this toggle off FEATURES-as-dict in 635edb98dc, so `should_redirect_to_authn_microfrontend()` now reads `settings.ENABLE_AUTHN_MICROFRONTEND`. Since production.py deliberately skips FEATURES when promoting YAML keys to Django settings, the old `FEATURES['ENABLE_AUTHN_MICROFRONTEND']` assignment had become a no-op and the LMS kept serving the legacy login page. Co-Authored-By: Claude <noreply@anthropic.com>
46c0fba to
f0c6599
Compare
|
Merging this sooner rather than later, so that developers can start using it to develop the landed frontend-base conversions. |
Description
Move the site and the npm_version defaults to frontend-base 2.0 together. And with all four apps on 2.0, Authn and Learner Dashboard join Instructor Dashboard and Notifications in being enabled by default.
Catalog joins them as the fifth core app, also enabled by default.
Closes openedx/frontend-app-catalog#146.
Dependencies
This is in draft until the following is resolved, at which point the site's
package-lock.jsonwill need to be refreshed:LLM usage notice
Built with assistance from Claude.