Repository navigation
Conversation
The pinned mordant reports nothing for generic_body_not_generic in src/io/pipes.rs and src/watcher/Watcher.rs, and nothing for parallel_vecs in src/js_printer/lib.rs. Later edits to those files removed the flagged shapes. The ratchet tolerates an over-count, so the lines stayed. Remove them and the three section headers they leave empty.
|
Updated 3:10 AM PT - Sep 14th, 2026
✅ @robobun, your commit dec9c2ac13eeb57c2242832501513c762f68352a passed in 🧪 To try this PR locally: bunx bun-pr 42698That installs a local version of the PR into your bun-42698 --bun |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. WalkthroughThe change removes the ChangesMordant baseline cleanup
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The change is limited to removing obsolete lint-baseline entries. No actionable merge risk is established from the available evidence. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — pure lint-baseline tightening, no code touched.
What was reviewed:
- Confirmed the diff only deletes three
(lint, file)entries and their now-empty section headers frommordant-baseline.toml; no other hunks. - Direction is safe: removing baseline allowance can only make the
mordantjob stricter, so a stale claim would fail CI rather than mask anything. - Checked CODEOWNERS —
mordant-baseline.tomlis not owned.
Extended reasoning...
Overview
This PR edits only the repo-root mordant-baseline.toml, deleting three suppression entries (generic_body_not_generic in src/io/pipes.rs and src/watcher/Watcher.rs, parallel_vecs in src/js_printer/lib.rs) along with the [bun_io], [bun_js_printer], and [bun_watcher] section headers that become empty. No Rust, C++, TypeScript, or test code is touched. The baseline file is a per-crate ratchet consumed by the advisory mordant dylint job; each entry records how many findings of a given lint in a given file CI will tolerate before flagging.
Security risks
None. The file is CI lint configuration only — it does not ship in the binary, affect runtime behavior, or gate any auth/crypto/permission path. No user-controlled input is parsed and no dependency surface changes.
Level of scrutiny
Low. This is a mechanical config-only cleanup in the safe direction: dropping baseline entries reduces tolerated findings, so if the PR author's claim that the underlying findings are gone were wrong, the mordant job on this very PR would surface it. Per REVIEW.md's "never silently weaken a safety net" rule, the concern is weakening — this is the opposite. There is no way for this diff to hide a regression; at worst it produces a visible CI failure.
Other factors
CODEOWNERS does not cover mordant-baseline.toml. The PR timeline shows no outstanding third-party objections. The bug hunt exited on dry_streak with no findings and nothing ruled out. The description gives a clear per-entry rationale (files changed after the baseline dates, flagged shapes gone, verified against pinned mordant 0d9bace), satisfying the "every hunk explainable" convention. Given the change is trivially reversible and self-verifying via CI, approval is appropriate.
|
Status: the |
|
Closing: this change is already on main. #43661 regenerated |
Problem
mordant-baseline.tomlholds three entries that no longer have a finding behind them:"generic_body_not_generic:src/io/pipes.rs" = 1"generic_body_not_generic:src/watcher/Watcher.rs" = 1"parallel_vecs:src/js_printer/lib.rs" = 1js_printer) and 2026-08-31 (the other two). All three files changed after that, and the flagged shapes are gone. The ratchet tolerates an over-count, so nothing removed the lines.Fix
[bun_io],[bun_js_printer]and[bun_watcher]section headers that they leave empty. No code change.0d9bace) on Linux. A run with an empty baseline prints every finding. It prints none for these three (lint, file) pairs. The other 144 entries match their recorded counts exactly.mordantjob on this PR is the check. It is advisory, so read its result directly.Background
Cargo.tomlunder[workspace.metadata.dylint]. Themordantjob in.github/workflows/rust-lints.ymlruns it.mordant-baseline.tomlis a ratchet. Each line is the number of findings accepted for one lint in one file. CI suppresses up to that number and fails only on overflow.no test proof · iteration 0 · no src or test change; test-proof not applicable