fix(test): rename transformers test file to match test runner glob#717
Open
wilsonwangdev wants to merge 1 commit intonodejs:mainfrom
Open
fix(test): rename transformers test file to match test runner glob#717wilsonwangdev wants to merge 1 commit intonodejs:mainfrom
wilsonwangdev wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
avivkeller
approved these changes
Mar 26, 2026
The test file at src/generators/metadata/utils/__tests__/transformers.mjs was never picked up by the test runner because the glob pattern is "src/**/*.test.mjs". Rename it to transformers.test.mjs so its 8 tests actually execute in CI.
f83cc61 to
d19d15b
Compare
AugustinMauroy
approved these changes
Mar 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
==========================================
+ Coverage 75.40% 76.33% +0.92%
==========================================
Files 148 148
Lines 13586 13586
Branches 1025 1052 +27
==========================================
+ Hits 10245 10371 +126
+ Misses 3336 3210 -126
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test file at
src/generators/metadata/utils/__tests__/transformers.mjswas never picked up by the test runner because the glob pattern inpackage.jsonis"src/**/*.test.mjs". This file contains 8 tests fortransformTypeToReferenceLinkthat have never executed in CI.This PR simply renames it to
transformers.test.mjsso the tests are included in test runs.Validation
After renaming, ran the file directly to confirm all 8 tests pass:
Check List
node --run testand all tests passed.node --run format&node --run lint.