Skip to content

Test requests are in CBOR canonical form - #381

Merged
jschanck merged 3 commits into
mozilla:ctap2-2021from
micolous:issue-225
Oct 8, 2026
Merged

jschanck merged 3 commits into
mozilla:ctap2-2021from
micolous:issue-225

Conversation

@micolous

@micolous micolous commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Rebase of #328 to current HEAD, with some small changes:

  • Made assert_canonical_cbor_encoding only available in test configurations
  • Formatting fixes
  • Adding checks to tests added after that PR was created
  • Removed redundant checks

Fixes #225

Replaces #328

@jschanck jschanck left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jschanck
jschanck merged commit b204525 into mozilla:ctap2-2021 Oct 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit for use of CTAP2 canonical CBOR encoding

3 participants