Repository navigation
Add tests to check that all CBOR requests are in canonicalized form - #328
Closed
EliasHolzmann wants to merge 1 commit into
Closed
EliasHolzmann wants to merge 1 commit into
EliasHolzmann wants to merge 1 commit into
Conversation
EliasHolzmann
force-pushed
the
cbor_canonicalization_tests
branch
from
January 6, 2024 02:04
532c3d5 to
a889d1b
Compare
Collaborator
|
I've rebased this against current HEAD in #381 with some extra fixes, so will track it there. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds just tests (and changes some visibilities where necessary) – I found no requests that weren't already meeting the canonicalization requirements, so the behavior of the lib itself stays unchanged.
Closes #225.