Skip to content

Annotations flag - #1700

Merged
dhosterman merged 5 commits into
mainfrom
annotations-flag
Oct 21, 2026
Merged

dhosterman merged 5 commits into
mainfrom
annotations-flag

Conversation

@dhosterman

Copy link
Copy Markdown
Collaborator

No description provided.

In this case, we want to ensure that both --annotations is passed AND
the prompts are shareable.
@dhosterman dhosterman self-assigned this Oct 19, 2026
@dhosterman
dhosterman deployed to Scheduled Testing October 19, 2026 16:23 — with GitHub Actions Active
@dhosterman
dhosterman requested a review from a team as a code owner October 19, 2026 16:23
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@rogthefrog rogthefrog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Comment thread src/modelbench/cli.py Resolved
@dhosterman
dhosterman deployed to Scheduled Testing October 20, 2026 18:59 — with GitHub Actions Active
Comment thread src/modelbench/cli.py
try:
run_and_report_benchmark(benchmark, sut, max_instances, debug, json_logs, run_path, output_dir, run_uid, user)
run_and_report_benchmark(
benchmark, sut, max_instances, debug, json_logs, run_path, output_dir, run_uid, user, include_annotations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for this PR, but at some point we should refactor to extract object(s) from this long parameter list.

Comment thread tests/modelbench_tests/test_run.py Resolved
@dhosterman
dhosterman deployed to Scheduled Testing October 21, 2026 19:50 — with GitHub Actions Active
@dhosterman
dhosterman merged commit d016bd1 into main Oct 21, 2026
3 checks passed

This branch was successfully deployed

1 active deployment
Scheduled Testing — dd6a0b51 Deployed Oct 21, 2026 by dhosterman via build #2612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants