Repository navigation
Fix official annotation filtering for private evaluator IDs - #1714
Open
confiscate wants to merge 1 commit into
Open
confiscate wants to merge 1 commit into
confiscate wants to merge 1 commit into
Conversation
|
MLCommons CLA bot: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-privatetest IDsBackground
BenchmarkRun.compile_annotations()previously unpacked test UIDs into exactly five hyphen-separated fields. ModelBench CLI runs use the private evaluator, which appends-private; that caused parsing to fail and classified the prompt set asunknown. Non-shareable prompt metadata normally provided a second safeguard, but the explicit guarantee that official prompt sets never export annotations was not reliably enforced.This is related to #1692 and hardens the existing annotation-export path added by #1700. It does not add SKU parsing or claim to implement the external SKU-to-CLI mapping.
Tests
uv run pytest tests/modelbench_tests/test_run.py -q— 36 passed, 1 skippeduv run pytest tests/modelbench_tests -q— 411 passed, 1 skippeduv run black --check src/modelbench tests/modelbench_testsgit diff --check