Repository navigation
Retire pre-v0.9 compatibility scaffolding - #1421
Closed
Gudge (MGudgin) wants to merge 1 commit into
Closed
Gudge (MGudgin) wants to merge 1 commit into
Gudge (MGudgin) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
3 of 8 tasks
This was referenced Oct 6, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
An unused mutable binding causes macOS test-target Clippy checks with warnings treated as errors to fail.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Completes the cleanup following #1382 and #1383 by removing pre-v0.9 compatibility scaffolding while retaining published schemas.
Changes:
- Remove constant compatibility markers and unused network wire fields.
- Simplify backend paths and related tests.
- Retire outdated guides and document the policy-hash projection change.
| File | Description |
|---|---|
| tests/scripts/run_lxc_network_no_network_test.sh | Update contract references and failure text. |
| tests/scripts/lib/WinProcessContainer.Common.ps1 | Update documentation reference. |
| src/mxc-sdk/src/policy.rs | Remove obsolete marker assertion. |
| src/mxc-sdk/src/core/mxc_engine/run.rs | Simplify attribution tests. |
| src/mxc-sdk/src/core/mxc_common/wire.rs | Remove retired network fields and enums. |
| src/mxc-sdk/src/core/mxc_common/validator.rs | Replace legacy support constant with default. |
| src/mxc-sdk/src/core/mxc_common/sdk_input.rs | Remove obsolete normalization fields. |
| src/mxc-sdk/src/core/mxc_common/script_runner.rs | Use default network support. |
| src/mxc-sdk/src/core/mxc_common/sandbox_process.rs | Use default network support. |
| src/mxc-sdk/src/core/mxc_common/policy_identity.rs | Remove compatibility marker from hashes. |
| src/mxc-sdk/src/core/mxc_common/network_parser.rs | Simplify network test fixtures. |
| src/mxc-sdk/src/core/mxc_common/network_parser_ingress_default_tests.rs | Update fixtures and contract references. |
| src/mxc-sdk/src/core/mxc_common/models.rs | Remove compatibility types and helpers. |
| src/mxc-sdk/src/core/mxc_common/default_env.rs | Simplify environment test setup. |
| src/mxc-sdk/src/core/mxc_common/config_parser.rs | Remove compatibility propagation and assertions. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v1_0/state_aware.rs | Remove obsolete adapter fields. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v1_0/state_aware_tests/exec.rs | Remove retired-field assertions. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v1_0/one_shot.rs | Remove compatibility markers. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v1_0/one_shot_tests/stable_candidate.rs | Assert supported network fields. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v1_0/common.rs | Simplify network conversion. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v0_9/state_aware.rs | Remove obsolete adapter fields. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v0_9/state_aware_tests/exec.rs | Remove retired-field assertions. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v0_9/one_shot.rs | Remove compatibility markers. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v0_9/one_shot_tests/stable_candidate.rs | Assert supported network fields. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/v0_9/common.rs | Simplify network conversion. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/dev/state_aware.rs | Remove obsolete adapter fields. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/dev/state_aware_tests/provision.rs | Update empty-network assertions. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/dev/state_aware_tests/exec.rs | Remove retired-field assertions. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/dev/one_shot.rs | Remove compatibility markers. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/dev/one_shot_tests/stable_candidate.rs | Assert supported network fields. |
| src/mxc-sdk/src/core/mxc_common/config_contract_adapters/dev/common.rs | Simplify network conversion. |
| src/mxc-sdk/src/core/mxc_common/common_request_ir.rs | Remove compatibility metadata. |
| src/mxc-sdk/src/configs/process_container.rs | Remove obsolete marker assertion. |
| src/mxc-sdk/src/backends/wslc/common/state_aware.rs | Simplify environment test cases. |
| src/mxc-sdk/src/backends/wslc/common/process_env.rs | Simplify environment fixtures. |
| src/mxc-sdk/src/backends/windows_sandbox/lifecycle/state_aware.rs | Use default network support. |
| src/mxc-sdk/src/backends/windows_sandbox/lifecycle/one_shot.rs | Use default network support. |
| src/mxc-sdk/src/backends/seatbelt/common/seatbelt_runner.rs | Remove unreachable environment fallback. |
| src/mxc-sdk/src/backends/seatbelt/common/default_env.rs | Simplify environment tests. |
| src/mxc-sdk/src/backends/lxc/common/lxc_runner.rs | Remove obsolete directory-resolution branch. |
| src/mxc-sdk/src/backends/isolation_session/common/policy.rs | Simplify environment validation tests. |
| src/mxc-sdk/src/backends/hyperlight/common/mod.rs | Use default network support. |
| src/mxc-sdk/src/backends/bubblewrap/common/proxy_network.rs | Remove test compatibility marker. |
| src/mxc-sdk/src/backends/bubblewrap/common/bwrap_runner.rs | Remove unreachable host-firewall lifecycle. |
| src/mxc-sdk/src/backends/bubblewrap/common/bwrap_command.rs | Remove legacy modes and compatibility gates. |
| sdk/node/README.md | Link supported networking guidance. |
| sdk/dotnet/README.md | Link supported networking guidance. |
| README.md | Remove retired policy-guide link. |
| docs/versioning.md | Clarify supported contracts and schema retention. |
| docs/telemetry/telemetry.md | Explain policy-hash projection change. |
| docs/seatbelt/seatbelt-backend.md | Link supported network fields. |
| docs/sandbox-policy/0.8.0/policy.md | Delete retired policy guide. |
| docs/sandbox-policy/0.8.0/networking/schema-updates.md | Delete retired migration guide. |
| docs/sandbox-policy/0.8.0/networking/networking.md | Delete retired networking guide. |
| docs/sandbox-policy/0.7.0/policy.md | Delete retired policy specification. |
| docs/reference/dotnet/v1/types.md | Correct minimum version and terminology. |
| docs/process-container/os-version-support.md | Distinguish retired and supported networking. |
| docs/process-container/networking.md | Link current shared schema guidance. |
| docs/process-container/guide.md | Update supported-networking guidance. |
| docs/process-container/examples/0.8.0-schema.md | Replace retired documentation links. |
| docs/examples.md | Point examples to supported guidance. |
| docs/ci-validation-infrastructure.md | Update networking coverage descriptions. |
| docs/authoring-a-new-feature.md | Replace retired policy references. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
3 of 8 tasks
This PR removes obsolete contract and runtime compatibility markers now that executable requests start at 0.9.0-alpha. Published schema artifacts stay immutable while unsupported policy guides are removed. Details * Remove constant default-environment and strict-network provenance. * Prune unused wire fields and obsolete policy documentation. * Preserve exact-contract validation and supported request semantics. Tests * cargo fmt --all -- --check and cargo test --workspace --quiet: passed. * cargo check --workspace --all-targets --all-features --quiet: passed. * cargo clippy --workspace --all-targets --all-features --quiet -- -D warnings: passed. * Linux Bubblewrap runner: 30 passed; schema history: 9 passed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7570a662-a429-46d2-aa24-47fae6655cc4 Generated-with: gpt-6-sol
Gudge (MGudgin)
force-pushed
the
user/gudge/retire-network-foundation
branch
from
October 6, 2026 22:56
610730a to
d01cac2
Compare
Member
Author
|
Superseded by merged #1397, which includes the foundation cleanup in this stacked PR. Closing this alternative PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR removes obsolete pre-v0.9 contract and runtime scaffolding now that executable requests start at 0.9.0-alpha. It retires constant default-environment and strict-network provenance, unused wire markers, and unsupported policy guides while retaining published stable schema artifacts.
Details
🔗 References
Follow-up to #1382 and #1383. The next PR in this stack targets this branch.
🔍 Validation
Tests
src/,cargo fmt --all -- --check: passed.cargo check --workspace --all-targets --all-features --quiet: passed.cargo clippy --workspace --all-targets --all-features --quiet -- -D warnings: passed.cargo test --workspace --quiet: passed.src/,cargo check -p mxc-sdk --all-targets --quiet: passed.cargo test -p mxc-sdk --lib bubblewrap::common::bwrap_runner --quiet: 30 passed.node --test scripts/versioning/tests/check-contract-codegen.test.js: 9 passed.node scripts/versioning/check-contract-codegen.js --check: passed; three exact artifact sets matched.✅ Checklist
Cargo.lock, thedependency-feed-checkcheck passes (see docs/pull-requests.md)📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHubActions build; it runs on merge to
main, and Microsoft reviewers with write access can trigger iton a PR with
/azp run. See docs/pull-requests.md.If the
dependency-feed-checkcheck fails on a new dependency, the crate must be added tothe feed before the PR can pass. See docs/pull-requests.md
for the steps.
Microsoft Reviewers: Open in CodeFlow