Skip to content

Retire pre-v0.9 Windows and VM backend paths - #1422

Closed
Gudge (MGudgin) wants to merge 1 commit into
user/gudge/retire-network-foundationfrom
user/gudge/retire-network-windows-vm
Closed

Gudge (MGudgin) wants to merge 1 commit into
user/gudge/retire-network-foundationfrom
user/gudge/retire-network-windows-vm

Conversation

@MGudgin

@MGudgin Gudge (MGudgin) commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

📖 Description

This PR removes unreachable pre-v0.9 backend networking paths in WSLc, ProcessContainer, Windows Sandbox, Hyperlight, NanVix, and AppContainer. Supported directional requests remain fail-closed before provisioning, and ProcessContainer audit behavior is preserved.

Details

  • Retire obsolete host-filter and firewall-manager paths.
  • Derive ProcessContainer capabilities and audit defaults from directional policy.
  • Preserve direct Hyperlight preflight without revalidating normal execution.
  • Clarify that Windows Sandbox rejects even empty or deny-only directional sections.

🔗 References

Depends on #1421. Follow-up to #1382 and #1383.

🔍 Validation

Tests

  • From src/, cargo fmt --all -- --check: passed.
  • cargo check --workspace --all-targets --all-features --quiet: passed.
  • cargo clippy --workspace --all-targets --all-features --quiet -- -D warnings: passed.
  • cargo test --workspace --quiet: passed.
  • cargo test -p mxc-sdk --lib --features wslc,isolation_session,microvm,hyperlight --quiet: 3,442 passed, 3 ignored.
  • Debian WSL, from src/, cargo check -p mxc-sdk --all-targets --quiet: passed.
  • Host-dependent Windows Sandbox, ProcessContainer, WSLc, and VM integration tests were not run locally.

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task

GitHub Actions runs the PR validation build automatically. The ADO pipeline
(MXC-PR-Build) is the Azure version of the PR pipeline, kept in parity with the GitHub
Actions build; it runs on merge to main, and Microsoft reviewers with write access can trigger it
on a PR with /azp run. See docs/pull-requests.md.

If the dependency-feed-check check fails on a new dependency, the crate must be added to
the feed before the PR can pass. See docs/pull-requests.md
for the steps.

Microsoft Reviewers: Open in CodeFlow

@MGudgin
Gudge (MGudgin) requested a review from a team as a code owner October 6, 2026 21:17
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

This PR removes unreachable old-version network paths in WSLc,
ProcessContainer, Windows Sandbox, Hyperlight, NanVix, and AppContainer.
Unsupported direct requests still fail before provisioning.

Details

* Retire host-filter processes and the obsolete firewall manager.
* Derive network capabilities and audit records from directional policy.
* Avoid redundant Hyperlight validation on normal execution.

Tests

* cargo fmt --all -- --check and cargo test --workspace --quiet: passed.
* cargo check --workspace --all-targets --all-features --quiet: passed.
* cargo clippy --workspace --all-targets --all-features --quiet --
  -D warnings: passed.
* Feature suite: 3442 passed, 3 ignored; Linux SDK check passed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 7570a662-a429-46d2-aa24-47fae6655cc4
Generated-with: gpt-6-sol
@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/retire-network-foundation branch from 610730a to d01cac2 Compare October 6, 2026 22:56
@MGudgin
Gudge (MGudgin) force-pushed the user/gudge/retire-network-windows-vm branch from 2544f21 to d4d9e17 Compare October 6, 2026 23:01
@MGudgin

Copy link
Copy Markdown
Member Author

Superseded by merged #1397, which includes the Windows and VM cleanup in this stacked PR. Closing this alternative PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant