-
Notifications
You must be signed in to change notification settings - Fork 22
Add new metadata fields from zwave-js v15.21.0 / SCHEMA 46 #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ | |
| # minimal server schema version we can handle | ||
| MIN_SERVER_SCHEMA_VERSION = 44 | ||
| # max server schema version we can handle (and our code is compatible with) | ||
| MAX_SERVER_SCHEMA_VERSION = 44 | ||
| MAX_SERVER_SCHEMA_VERSION = 46 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to process the other PR that adds support for schema 45 first.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I looked at that - couldn't find anything requiring changes here. The existing code already expects dicts, and the upstream fix made sure those dicts are actually filled and not just Bumping the schema there may have been overly cautious.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok. I don't think this changes anything at this point. We need to merge support for schema 45 before schema 46.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ohh. I didn't see the other pending PR. The upstream work for that isn't even merged in zwave-js-server though. @raman325 any suggestions on how to consolidate?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I pushed a PR for schema 45. I didn't see this one so I pushed one for schema 46 as well. I can close that in favor of this one or vice versa doesn't matter to me - thoughts @MartinHjelmare ? Regardless I do have schema 47 started and will continue working through that once one of these PRs is merged |
||
|
|
||
| VALUE_UNKNOWN = "unknown" | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this needs to be bumped. We just added support for optional properties.