Add new metadata fields from zwave-js v15.21.0 / SCHEMA 46#1367
Add new metadata fields from zwave-js v15.21.0 / SCHEMA 46#1367AlCalzone wants to merge 4 commits intohome-assistant-libs:mainfrom
Conversation
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Is this data passed through from the server without any changes in the server?
|
This needs a new release of zwave-js-server with a schema bump. Going back to draft for now. |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
| @@ -13,7 +13,7 @@ | |||
| # minimal server schema version we can handle | |||
| MIN_SERVER_SCHEMA_VERSION = 44 | |||
There was a problem hiding this comment.
I'm not sure if this needs to be bumped. We just added support for optional properties.
AlCalzone
changed the title
| MIN_SERVER_SCHEMA_VERSION = 44 | ||
| # max server schema version we can handle (and our code is compatible with) | ||
| MAX_SERVER_SCHEMA_VERSION = 44 | ||
| MAX_SERVER_SCHEMA_VERSION = 46 |
There was a problem hiding this comment.
We need to process the other PR that adds support for schema 45 first.
There was a problem hiding this comment.
I looked at that - couldn't find anything requiring changes here. The existing code already expects dicts, and the upstream fix made sure those dicts are actually filled and not just {}.
Bumping the schema there may have been overly cautious.
There was a problem hiding this comment.
Ok. I don't think this changes anything at this point. We need to merge support for schema 45 before schema 46.
There was a problem hiding this comment.
Ohh. I didn't see the other pending PR. The upstream work for that isn't even merged in zwave-js-server though.
@raman325 any suggestions on how to consolidate?
There was a problem hiding this comment.
I pushed a PR for schema 45. I didn't see this one so I pushed one for schema 46 as well. I can close that in favor of this one or vice versa doesn't matter to me - thoughts @MartinHjelmare ?
Regardless I do have schema 47 started and will continue working through that once one of these PRs is merged
|
other PR was merged |
3 participants
https://github.com/zwave-js/zwave-js/releases/tag/v15.21.0 adds new metadata fields:
allowedfor defining value ranges with gaps and step sizes on config parameters and other value metadatapurposefor annotating a config parameter with a semantic meaning.This PR adds both to the client lib.