Fix: ranking round threshold validation#384
Open
Oyelakin-Mercy wants to merge 1 commit into
Open
Conversation
Oyelakin-Mercy
force-pushed
the
fix/ranking-round-threshold-validation
branch
from
ef7203b to
05630ca
Compare
lgelauff
requested changes
Apr 27, 2026
lgelauff
left a comment
lgelauff
left a comment
Collaborator
There was a problem hiding this comment.
This seems to be a working frontend fix. However, if you have the opportunity, it might be nice to also add a backend fix to at least give an informative error.
This was referenced Apr 27, 2026
lgelauff
force-pushed
the
fix/ranking-round-threshold-validation
branch
from
05630ca to
c11e300
Compare
Collaborator
|
I addressed myself. I believe this is now ready for approval |
Jayprakash-SE
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #383
What changed:
i18nkey for the error messageBefore:
After:
