fix(backend): return 400 instead of 500 when threshold is null in advance_round#533
Open
lgelauff wants to merge 2 commits into
Open
fix(backend): return 400 instead of 500 when threshold is null in advance_round#533lgelauff wants to merge 2 commits into
lgelauff wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #383.
What changed
Frontend (cherry-picked from #384, authored by @Oyelakin-Mercy): validates that a threshold is selected before submitting the advance-round form, showing a specific error message (
montage-required-threshold) rather than letting the request through.Backend (
admin_endpoints.py): the existingexcept KeyErrordid not catch the case wherethresholdis present in the request but set tonull—float(None)raisesTypeError, notKeyError, so the exception propagated as an unhandled 500. Fix catchesTypeErrorandValueErroralongsideKeyError.i18n: adds the missing
qqq.jsondocumentation entry formontage-required-threshold.Reproduction
python .claude/reproduce_383.py # requires local instance with debug: trueBefore:
threshold: null→ 500 Internal Server ErrorAfter:
threshold: null→ 400 with"unset threshold. set the threshold and try again."