Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ dependencies = [
[project.optional-dependencies]
dev = [
"pytest>=7.0",
"pytest-asyncio>=0.21",
"pytest-asyncio>=1.2.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Incomplete version bump: setup.py and requirements-dev.txt still pin pytest-asyncio>=0.21

The pytest-asyncio version constraint was updated to >=1.2.0 in pyproject.toml but the same dependency is still declared as >=0.21 in setup.py:41 and requirements-dev.txt:3. This means developers installing via pip install -e ".[dev]" using setup.py or pip install -r requirements-dev.txt could resolve to an older 0.x version of pytest-asyncio that this PR presumably intends to exclude. The three files should specify consistent version constraints for the same dependency.

Prompt for agents
The pytest-asyncio version constraint was updated to >=1.2.0 in pyproject.toml but not in the two other files that also declare this dependency:

1. setup.py line 41: still has "pytest-asyncio>=0.21"
2. requirements-dev.txt line 3: still has "pytest-asyncio>=0.21"

Both of these files should be updated to match the new constraint "pytest-asyncio>=1.2.0" to keep all dependency specifications consistent. Otherwise, developers using setup.py or requirements-dev.txt to install dependencies could end up with an older version of pytest-asyncio that this PR is meant to move past.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

"pytest-cov>=4.0",
"black>=23.0",
"isort>=5.12",
Expand Down
Loading