deps-dev(deps-dev): update pytest-asyncio requirement from >=0.21 to >=1.2.0#29
Open
dependabot[bot] wants to merge 1 commit into
Open
deps-dev(deps-dev): update pytest-asyncio requirement from >=0.21 to >=1.2.0#29dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Updates the requirements on [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v0.21.0...v1.2.0) --- updated-dependencies: - dependency-name: pytest-asyncio dependency-version: 1.2.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
| dev = [ | ||
| "pytest>=7.0", | ||
| "pytest-asyncio>=0.21", | ||
| "pytest-asyncio>=1.2.0", |
There was a problem hiding this comment.
🟡 Incomplete version bump: setup.py and requirements-dev.txt still pin pytest-asyncio>=0.21
The pytest-asyncio version constraint was updated to >=1.2.0 in pyproject.toml but the same dependency is still declared as >=0.21 in setup.py:41 and requirements-dev.txt:3. This means developers installing via pip install -e ".[dev]" using setup.py or pip install -r requirements-dev.txt could resolve to an older 0.x version of pytest-asyncio that this PR presumably intends to exclude. The three files should specify consistent version constraints for the same dependency.
Prompt for agents
The pytest-asyncio version constraint was updated to >=1.2.0 in pyproject.toml but not in the two other files that also declare this dependency:
1. setup.py line 41: still has "pytest-asyncio>=0.21"
2. requirements-dev.txt line 3: still has "pytest-asyncio>=0.21"
Both of these files should be updated to match the new constraint "pytest-asyncio>=1.2.0" to keep all dependency specifications consistent. Otherwise, developers using setup.py or requirements-dev.txt to install dependencies could end up with an older version of pytest-asyncio that this PR is meant to move past.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on pytest-asyncio to permit the latest version.
Release notes
Sourced from pytest-asyncio's releases.
Commits
0d3988fci: Create GitHub release before publishing to PyPI.07c5a0bdocs: Include orphaned news fragment in changelog.be24582chore: Prepare release of v1.2.0.7aeb296docs: Streamline news fragments7b8311cci: Fixes a bug that prevented SSH signature from being stripped from release...9d4c2bddocs: Add changelog entry for Pyright compatibility.94f6106test: Added tests which assert that the event loop is reinstated if unset by ...df61991[pre-commit.ci] pre-commit autoupdatef1f7941Build(deps): Bump pytest from 8.4.1 to 8.4.2c77d3d3Build(deps): Bump twine from 6.1.0 to 6.2.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)