Skip to content

Fix serializating the random number generator for the CPO Bingham particle property. - #7293

Open
bangerth wants to merge 2 commits into
geodynamics:mainfrom
bangerth:cpo
Open

Fix serializating the random number generator for the CPO Bingham particle property.#7293
bangerth wants to merge 2 commits into
geodynamics:mainfrom
bangerth:cpo

Conversation

@bangerth

@bangerth bangerth commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Describe what you did in this PR and why you did it.

This addresses one of the other places where we have a random number generator in plugins. This class actually serializes it, but as with the other places we had, this does not lead to reproducible results because (i) we really only save the state from process, but (ii) restore all processes from the saved state from process 0. The scheme used here ensures reproducible restarts.

Part of #6744.

Before your first pull request:

For all pull requests:

If yes, please describe your usage of AI models in the creation of this pull request

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@bangerth

Copy link
Copy Markdown
Contributor Author

Some of the test outputs change by noticeable amounts. I lack the understanding of these models to say whether that's reasonable.

@MFraters I think you wrote this class originally. Can you take a look?

@bangerth bangerth changed the title Fix serialization the random number generator for the CPO Bingham particle property. Fix serializating the random number generator for the CPO Bingham particle property. Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant