Fix serializating the random number generator for the CPO Bingham particle property. - #7293
Open
bangerth wants to merge 2 commits into
Open
Fix serializating the random number generator for the CPO Bingham particle property.#7293bangerth wants to merge 2 commits into
bangerth wants to merge 2 commits into
Conversation
Contributor
Author
|
Some of the test outputs change by noticeable amounts. I lack the understanding of these models to say whether that's reasonable. @MFraters I think you wrote this class originally. Can you take a look? |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what you did in this PR and why you did it.
This addresses one of the other places where we have a random number generator in plugins. This class actually serializes it, but as with the other places we had, this does not lead to reproducible results because (i) we really only save the state from process, but (ii) restore all processes from the saved state from process 0. The scheme used here ensures reproducible restarts.
Part of #6744.
Before your first pull request:
For all pull requests:
If yes, please describe your usage of AI models in the creation of this pull request
For new features/models or changes of existing features: